Python: Added Brave search capability in SK(python) based on PR #9632 #11531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
python/semantic_kernel/connectors/search_engine/brave_connector.py
Outdated
Show resolved
Hide resolved
Python Unit Test Overview
|
Reorganizes Brave Search connector by merging files into a single module for improved maintainability. Consolidates settings, response, and web page models. Updates imports and retains functionality.
…plugin implementation
N-E-W-T-O-N
force-pushed
the
pySearch
branch
2 times, most recently
from
4f942b2 to
26179d9
Compare
eavanvalkenburg
approved these changes
Apr 17, 2025
|
@eavanvalkenburg |
moonbox3
approved these changes
Apr 18, 2025
|
@N-E-W-T-O-N, the required GitHub jobs to run the workflow were never created. Can you push a dummy commit so the CI jobs are created? Something like: git commit --allow-empty -m "CI: retrigger"
git push |
|
@eavanvalkenburg |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
A vector index based error is occurred in pre merge integration test |
Yes. I’m aware. Need to investigate what’s going on. |
|
Thank you for your contribution, @N-E-W-T-O-N. We greatly appreciate it. |
4 tasks
glorious-beard
pushed a commit
to glorious-beard/semantic-kernel
that referenced
this pull request
May 6, 2025
…soft#9632 (microsoft#11531) ### Motivation and Context Added BRAVE SEARCH CAPABILITIES in Semantic Kernel Python based on PR microsoft#11308 . ### Description - Introduce BraveConnector & BraveSearch for Brave Search API integration, - BraveSettings and response models were added, respectively. - Add unit Tests ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Added BRAVE SEARCH CAPABILITIES in Semantic Kernel Python based on PR #11308 .
Description
Contribution Checklist