.Net: Update ITextSearch to align with search abstractions in M.E.VD - Phase 1 #11519

markwallace-microsoft · 2025-04-11T17:15:28Z

Motivation and Context

Change the return type of ITextSearch to align with search abstractions in M.E.VD
Make top a required parameter to align with search abstractions in M.E.VD

Description

Contribution Checklist

The code builds clean without any errors or warnings
The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
All unit tests pass, and I have added new tests where possible
I didn't break anyone 😄

…ns in M.E.VD

…methods

dotnet/samples/GettingStartedWithTextSearch/Step2_Search_For_RAG.cs

markwallace-microsoft requested a review from a team as a code owner April 11, 2025 17:15

markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel.core labels Apr 11, 2025

github-actions bot changed the title ~~Change the return type of ITextSearch to align with search abstractions in M.E.VD~~ .Net: Change the return type of ITextSearch to align with search abstractions in M.E.VD Apr 11, 2025

markwallace-microsoft had a problem deploying to integration April 11, 2025 17:15 — with GitHub Actions Failure

markwallace-microsoft force-pushed the users/markwallace/itextsearch_change_returns branch from 7b4f411 to c51671a Compare April 11, 2025 18:32

markwallace-microsoft marked this pull request as draft April 11, 2025 18:32

markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Apr 11, 2025

markwallace-microsoft had a problem deploying to integration April 11, 2025 18:32 — with GitHub Actions Failure

Change the return type of ItextSearch to align with search abstractio…

ef6444b

…ns in M.E.VD

markwallace-microsoft force-pushed the users/markwallace/itextsearch_change_returns branch from c51671a to ef6444b Compare April 11, 2025 19:21

markwallace-microsoft had a problem deploying to integration April 11, 2025 19:21 — with GitHub Actions Failure

Obsolete the old ITextSearch method signatures

0d40bc1

markwallace-microsoft had a problem deploying to integration April 11, 2025 20:36 — with GitHub Actions Failure

markwallace-microsoft marked this pull request as ready for review April 14, 2025 09:01

markwallace-microsoft marked this pull request as draft April 14, 2025 09:01

markwallace-microsoft had a problem deploying to integration April 14, 2025 11:10 — with GitHub Actions Failure

markwallace-microsoft force-pushed the users/markwallace/itextsearch_change_returns branch from 0a8dcec to 8ce32d0 Compare April 14, 2025 11:21

markwallace-microsoft had a problem deploying to integration April 14, 2025 11:21 — with GitHub Actions Failure

markwallace-microsoft force-pushed the users/markwallace/itextsearch_change_returns branch from 8ce32d0 to 1df6a70 Compare April 14, 2025 11:31

markwallace-microsoft had a problem deploying to integration April 14, 2025 11:31 — with GitHub Actions Failure

markwallace-microsoft force-pushed the users/markwallace/itextsearch_change_returns branch from 1df6a70 to e88b1da Compare April 14, 2025 11:39

markwallace-microsoft had a problem deploying to integration April 14, 2025 11:39 — with GitHub Actions Failure

Add extension methods that take a top parameter and obsolete the old …

bd82327

…methods

markwallace-microsoft force-pushed the users/markwallace/itextsearch_change_returns branch from e88b1da to bd82327 Compare April 14, 2025 12:45

markwallace-microsoft had a problem deploying to integration April 14, 2025 12:46 — with GitHub Actions Failure

Add supression file for API changes

d99ba15

markwallace-microsoft had a problem deploying to integration April 14, 2025 13:00 — with GitHub Actions Failure

Fix unit tests

415a833

markwallace-microsoft had a problem deploying to integration April 14, 2025 13:16 — with GitHub Actions Failure

Fix unit tests

b9cad0c

markwallace-microsoft had a problem deploying to integration April 14, 2025 13:31 — with GitHub Actions Failure

Fix AOT unit tests

02ddbb7

markwallace-microsoft had a problem deploying to integration April 14, 2025 13:55 — with GitHub Actions Failure

Fix AOT unit tests

32d2da1

markwallace-microsoft temporarily deployed to integration April 14, 2025 14:27 — with GitHub Actions Inactive

markwallace-microsoft temporarily deployed to integration April 14, 2025 14:46 — with GitHub Actions Inactive

markwallace-microsoft marked this pull request as ready for review April 14, 2025 15:02

markwallace-microsoft changed the title ~~.Net: Change the return type of ITextSearch to align with search abstractions in M.E.VD~~ .Net: Update ITextSearch to align with search abstractions in M.E.VD - Phase 1 Apr 14, 2025

markwallace-microsoft force-pushed the users/markwallace/itextsearch_change_returns branch from e10de52 to 038e3d7 Compare April 14, 2025 15:12

markwallace-microsoft had a problem deploying to integration April 14, 2025 15:13 — with GitHub Actions Error

Exclude obsolete methods rom code coverage

bbfca90

markwallace-microsoft force-pushed the users/markwallace/itextsearch_change_returns branch from 038e3d7 to bbfca90 Compare April 14, 2025 15:18

markwallace-microsoft temporarily deployed to integration April 14, 2025 15:19 — with GitHub Actions Inactive

westey-m reviewed Apr 14, 2025

View reviewed changes

dotnet/samples/GettingStartedWithTextSearch/Step2_Search_For_RAG.cs Outdated Show resolved Hide resolved

westey-m approved these changes Apr 14, 2025

View reviewed changes

SergeyMenshykh approved these changes Apr 14, 2025

View reviewed changes

Address code review feedback

d6d0135

markwallace-microsoft temporarily deployed to integration April 14, 2025 18:36 — with GitHub Actions Inactive

markwallace-microsoft merged commit af87cc0 into microsoft:feature-itextsearch-alignment Apr 14, 2025
11 checks passed

markwallace-microsoft mentioned this pull request Apr 14, 2025

.Net: Update ITextSearch to align with search abstractions in M.E.VD … #11551

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

.Net: Update ITextSearch to align with search abstractions in M.E.VD - Phase 1 #11519

.Net: Update ITextSearch to align with search abstractions in M.E.VD - Phase 1 #11519

Uh oh!

markwallace-microsoft commented Apr 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

.Net: Update ITextSearch to align with search abstractions in M.E.VD - Phase 1 #11519

.Net: Update ITextSearch to align with search abstractions in M.E.VD - Phase 1 #11519

Uh oh!

Conversation

markwallace-microsoft commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation and Context

Description

Contribution Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

markwallace-microsoft commented Apr 11, 2025 •

edited

Loading