.Net MEVD Replace VectorSearchResults with IAsyncEnumerable #11486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le<VectorSearchResult> rather than VectorSearchResults
markwallace-microsoft
added
.NET
adamsitnik
had a problem deploying
to
integration
GitHub Actions
Failure
roji
requested changes
Apr 10, 2025
There was a problem hiding this comment.
Looks good! 3 general comments:
- VectorizedSearchAsync also needs to have its return type changed, as the others
- There are some cases where it should be possible to just use AsAsyncEnumerable() and return the result from that, rather than making the method async and yielding results
- In many tests it should be possible to now merge the two lines together (i.e.
BlaBlaSearch().ToListAsync()
...s/Concepts/Memory/VectorStoreEmbeddingGeneration/TextEmbeddingVectorStoreRecordCollection.cs
Outdated
Show resolved
Hide resolved
dotnet/samples/Concepts/Memory/VectorStore_Langchain_Interop.cs
Outdated
Show resolved
Hide resolved
...ctors.AzureCosmosDBMongoDB.UnitTests/AzureCosmosDBMongoDBVectorStoreRecordCollectionTests.cs
Outdated
Show resolved
Hide resolved
...onnectors.AzureCosmosDBNoSQL.UnitTests/AzureCosmosDBNoSQLVectorStoreRecordCollectionTests.cs
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Postgres/PostgresVectorStoreRecordCollection.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Qdrant/QdrantVectorStoreRecordCollection.cs
Show resolved
Hide resolved
…o removeVSR # Conflicts: # dotnet/src/Connectors/Connectors.Memory.InMemory/InMemoryVectorStoreRecordCollection.cs
- change VectorizableTextSearchAsync as well - make sure provider-specific exceptions are wrapped with VectorStoreOperationException
westey-m
reviewed
Apr 11, 2025
...t/src/Connectors/Connectors.Memory.AzureAISearch/AzureAISearchVectorStoreRecordCollection.cs
Show resolved
Hide resolved
westey-m
approved these changes
Apr 11, 2025
roji
approved these changes
Apr 11, 2025
...t/src/Connectors/Connectors.Memory.AzureAISearch/AzureAISearchVectorStoreRecordCollection.cs
Outdated
Show resolved
Hide resolved
| @@ -56,7 +56,7 @@ public static async IAsyncEnumerable<T> WrapAsyncEnumerableAsync<T>( | |||
| var more = await enumerator.MoveNextAsync(); | |||
| return (enumerator.Current, more); | |||
| } | |||
| catch (Exception ex) | |||
| catch (Exception ex) when (ex is not (NotSupportedException or ArgumentException)) | |||
There was a problem hiding this comment.
I think we should be going the other way, and specifically identifying the exceptions we want to wrap. For example, this will still wrap OperationCanceledException.
I'd recommend not dealing with this in this PR, but doing a proper separate pass across all providers to check on the exception behavior, as discussed offline (#11512).
...t/src/Connectors/Connectors.Memory.AzureAISearch/AzureAISearchVectorStoreRecordCollection.cs
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Qdrant/QdrantVectorStoreRecordCollection.cs
Show resolved
Hide resolved
dotnet/samples/Concepts/Memory/VectorStore_Langchain_Interop.cs
Outdated
Show resolved
Hide resolved
- inline variables that just store the VectorizedSearchAsync result - reduce the number of places we perfom async foreach just to yield the results - make IncludeTotalCount obsolete
adamsitnik
added
the
msft.ext.vectordata
…3): error WHITESPACE: Fix whitespace formatting. Insert '\s'." I can't repro it locally, here is my attempt to fix it
adamsitnik
had a problem deploying
to
integration
GitHub Actions
Failure
…o removeVSR # Conflicts: # dotnet/src/IntegrationTests/Connectors/Memory/Weaviate/WeaviateVectorStoreRecordCollectionTests.cs
adamsitnik
merged commit 4f80c12
into
microsoft:feature-vector-data-preb2
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11048