.Net: Remove experimental flags for stable items #11346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
markwallace-microsoft
temporarily deployed
to
integration
GitHub Actions
Inactive
dmytrostruk
previously approved these changes
Apr 3, 2025
westey-m
previously approved these changes
Apr 3, 2025
|
Suggest removing those too as this is supported natively by the OpenAI SDK. |
RogerBarreto
reviewed
Apr 3, 2025
dotnet/src/SemanticKernel.Abstractions/Functions/KernelFunction.cs
Outdated
Show resolved
Hide resolved
RogerBarreto
reviewed
Apr 3, 2025
dotnet/src/SemanticKernel.Abstractions/Functions/KernelPlugin.cs
Outdated
Show resolved
Hide resolved
RogerBarreto
previously approved these changes
Apr 3, 2025
shethaadit
approved these changes
Apr 3, 2025
markwallace-microsoft
had a problem deploying
to
integration
GitHub Actions
Error
markwallace-microsoft
dismissed stale reviews from dmytrostruk, RogerBarreto, and westey-m
via
78255c0
markwallace-microsoft
temporarily deployed
to
integration
GitHub Actions
Inactive
westey-m
approved these changes
Apr 4, 2025
SergeyMenshykh
approved these changes
Apr 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I would recommend creating a second PR after this, removing any unused 🚢it. |
|
Following integration test failed: |
markwallace-microsoft
deleted the
users/markwallace/remove_experimental_250402
branch
glorious-beard
pushed a commit
to glorious-beard/semantic-kernel
that referenced
this pull request
Apr 6, 2025
### Motivation and Context 1. Native-AOT 2. OpenAI execution settings 3. ITextSearch 4. IChatHistoryReducer 5. Some Misc. core/abstractions experimental flags that are over 60 days ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Contribution Checklist