.Net: Make AgentThread.Create protected and expose on concrete implementations where possible

dotnet/src/Agents/Abstractions/Agent.cs

@@ -198,8 +198,6 @@ protected async Task<TThreadType> EnsureThreadExistsWithMessageAsync<TThreadType
             throw new KernelException($"{this.GetType().Name} currently only supports agent threads of type {nameof(TThreadType)}.");
         }
 
-        await thread.CreateAsync(cancellationToken).ConfigureAwait(false);
-
         // Notify the thread that new messages are available.
         foreach (var message in messages)
         {

dotnet/src/Agents/Abstractions/AgentThread.cs

@@ -31,7 +31,7 @@ public abstract class AgentThread
     /// </summary>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> to monitor for cancellation requests. The default is <see cref="CancellationToken.None"/>.</param>
     /// <returns>A task that completes when the thread has been created.</returns>
-    public virtual async Task CreateAsync(CancellationToken cancellationToken = default)
+    protected virtual async Task CreateAsync(CancellationToken cancellationToken = default)
     {
         if (this.IsDeleted)
         {

dotnet/src/Agents/AzureAI/AzureAIAgentThread.cs

@@ -61,6 +61,16 @@ public AzureAIAgentThread(AgentsClient client, string id)
         this.Id = id;
     }
 
+    /// <summary>
+    /// Creates the thread and returns the thread id.
+    /// </summary>
+    /// <param name="cancellationToken">The <see cref="CancellationToken"/> to monitor for cancellation requests. The default is <see cref="CancellationToken.None"/>.</param>
+    /// <returns>A task that completes when the thread has been created.</returns>
+    public new Task CreateAsync(CancellationToken cancellationToken = default)
+    {
+        return base.CreateAsync(cancellationToken);
+    }
+
     /// <inheritdoc />
     protected async override Task<string?> CreateInternalAsync(CancellationToken cancellationToken)
     {

dotnet/src/Agents/Core/ChatHistoryAgentThread.cs

@@ -36,6 +36,16 @@ public ChatHistoryAgentThread(ChatHistory chatHistory, string? id = null)
         this.Id = id ?? Guid.NewGuid().ToString("N");
     }
 
+    /// <summary>
+    /// Creates the thread and returns the thread id.
+    /// </summary>
+    /// <param name="cancellationToken">The <see cref="CancellationToken"/> to monitor for cancellation requests. The default is <see cref="CancellationToken.None"/>.</param>
+    /// <returns>A task that completes when the thread has been created.</returns>
+    public new Task CreateAsync(CancellationToken cancellationToken = default)
+    {
+        return base.CreateAsync(cancellationToken);
+    }
+
     /// <inheritdoc />
     protected override Task<string?> CreateInternalAsync(CancellationToken cancellationToken)
     {

dotnet/src/Agents/OpenAI/OpenAIAssistantAgentThread.cs

@@ -47,6 +47,16 @@ public OpenAIAssistantAgentThread(AssistantClient client, string id)
         this.Id = id;
     }
 
+    /// <summary>
+    /// Creates the thread and returns the thread id.
+    /// </summary>
+    /// <param name="cancellationToken">The <see cref="CancellationToken"/> to monitor for cancellation requests. The default is <see cref="CancellationToken.None"/>.</param>
+    /// <returns>A task that completes when the thread has been created.</returns>
+    public new Task CreateAsync(CancellationToken cancellationToken = default)
+    {
+        return base.CreateAsync(cancellationToken);
+    }
+
     /// <inheritdoc />
     protected async override Task<string?> CreateInternalAsync(CancellationToken cancellationToken)
     {

dotnet/src/Agents/UnitTests/Core/AgentThreadTests.cs

@@ -147,6 +147,11 @@ private sealed class TestAgentThread : AgentThread
         public int DeleteInternalAsyncCount { get; private set; }
         public int OnNewMessageInternalAsyncCount { get; private set; }
 
+        public new Task CreateAsync(CancellationToken cancellationToken = default)
+        {
+            return base.CreateAsync(cancellationToken);
+        }
+
         protected override Task<string?> CreateInternalAsync(CancellationToken cancellationToken)
         {
             this.CreateInternalAsyncCount++;

dotnet/src/IntegrationTests/Agents/CommonInterfaceConformance/AgentFixture.cs

@@ -17,6 +17,8 @@ public abstract class AgentFixture : IAsyncLifetime
 
     public abstract AgentThread AgentThread { get; }
 
+    public abstract AgentThread CreatedAgentThread { get; }
+
     public abstract AgentThread ServiceFailingAgentThread { get; }
 
     public abstract AgentThread CreatedServiceFailingAgentThread { get; }

dotnet/src/IntegrationTests/Agents/CommonInterfaceConformance/AgentThreadConformance/AgentThreadTests.cs

@@ -20,20 +20,16 @@ public abstract class AgentThreadTests(Func<AgentFixture> createAgentFixture) :
     [Fact]
     public virtual async Task DeletingThreadTwiceDoesNotThrowAsync()
     {
-        await this.Fixture.AgentThread.CreateAsync();
-
-        await this.Fixture.AgentThread.DeleteAsync();
-        await this.Fixture.AgentThread.DeleteAsync();
+        await this.Fixture.CreatedAgentThread.DeleteAsync();
+        await this.Fixture.CreatedAgentThread.DeleteAsync();
     }
 
     [Fact]
     public virtual async Task UsingThreadAfterDeleteThrowsAsync()
     {
-        await this.Fixture.AgentThread.CreateAsync();
-        await this.Fixture.AgentThread.DeleteAsync();
+        await this.Fixture.CreatedAgentThread.DeleteAsync();
 
-        await Assert.ThrowsAsync<InvalidOperationException>(async () => await this.Fixture.AgentThread.CreateAsync());
-        await Assert.ThrowsAsync<InvalidOperationException>(async () => await this.Fixture.AgentThread.OnNewMessageAsync(new ChatMessageContent(AuthorRole.User, "Hi")));
+        await Assert.ThrowsAsync<InvalidOperationException>(async () => await this.Fixture.CreatedAgentThread.OnNewMessageAsync(new ChatMessageContent(AuthorRole.User, "Hi")));
     }
 
     [Fact]
@@ -49,12 +45,6 @@ public virtual async Task UsingThreadbeforeCreateCreatesAsync()
         Assert.NotNull(this.Fixture.AgentThread.Id);
     }
 
-    [Fact]
-    public virtual async Task CreateThreadWithServiceFailureThrowsAgentOperationExceptionAsync()
-    {
-        await Assert.ThrowsAsync<AgentThreadOperationException>(async () => await this.Fixture.ServiceFailingAgentThread.CreateAsync());
-    }
-
     [Fact]
     public virtual async Task DeleteThreadWithServiceFailureThrowsAgentOperationExceptionAsync()
     {

dotnet/src/IntegrationTests/Agents/CommonInterfaceConformance/AgentThreadConformance/ChatCompletionAgentThreadTests.cs

@@ -7,13 +7,6 @@ namespace SemanticKernel.IntegrationTests.Agents.CommonInterfaceConformance.Agen
 
 public class ChatCompletionAgentThreadTests() : AgentThreadTests(() => new ChatCompletionAgentFixture())
 {
-    [Fact]
-    public override Task CreateThreadWithServiceFailureThrowsAgentOperationExceptionAsync()
-    {
-        // Test not applicable since there is no service to fail.
-        return Task.CompletedTask;
-    }
-
     [Fact]
     public override Task DeleteThreadWithServiceFailureThrowsAgentOperationExceptionAsync()
     {

dotnet/src/IntegrationTests/Agents/CommonInterfaceConformance/AzureAIAgentFixture.cs

@@ -26,13 +26,16 @@ public class AzureAIAgentFixture : AgentFixture
     private AAIP.Agent? _aiAgent;
     private AzureAIAgent? _agent;
     private AzureAIAgentThread? _thread;
+    private AzureAIAgentThread? _createdThread;
     private AzureAIAgentThread? _serviceFailingAgentThread;
     private AzureAIAgentThread? _createdServiceFailingAgentThread;
 
     public override Agent Agent => this._agent!;
 
     public override AgentThread AgentThread => this._thread!;
 
+    public override AgentThread CreatedAgentThread => this._createdThread!;
+
     public override AgentThread ServiceFailingAgentThread => this._serviceFailingAgentThread!;
 
     public override AgentThread CreatedServiceFailingAgentThread => this._createdServiceFailingAgentThread!;
@@ -65,6 +68,14 @@ public override async Task DisposeAsync()
             }
         }
 
+        try
+        {
+            await this._agentsClient!.DeleteThreadAsync(this._createdThread!.Id);
+        }
+        catch (RequestFailedException ex) when (ex.Status == 404)
+        {
+        }
+
         try
         {
             await this._agentsClient!.DeleteThreadAsync(this._createdServiceFailingAgentThread!.Id);
@@ -95,6 +106,9 @@ await this._agentsClient.CreateAgentAsync(
         this._agent = new AzureAIAgent(this._aiAgent, this._agentsClient) { Kernel = kernel };
         this._thread = new AzureAIAgentThread(this._agentsClient);
 
+        this._createdThread = new AzureAIAgentThread(this._agentsClient);
+        await this._createdThread.CreateAsync();
+
         var serviceFailingClient = AzureAIAgent.CreateAzureAIClient("swedencentral.api.azureml.ms;<subscription_id>;<resource_group_name>;<project_name>", new AzureCliCredential());
         this._serviceFailingAgentThread = new AzureAIAgentThread(serviceFailingClient.GetAgentsClient());
 

dotnet/src/IntegrationTests/Agents/CommonInterfaceConformance/ChatCompletionAgentFixture.cs

@@ -24,11 +24,14 @@ public class ChatCompletionAgentFixture : AgentFixture
 
     private ChatCompletionAgent? _agent;
     private ChatHistoryAgentThread? _thread;
+    private ChatHistoryAgentThread? _createdThread;
 
     public override Agent Agent => this._agent!;
 
     public override AgentThread AgentThread => this._thread!;
 
+    public override AgentThread CreatedAgentThread => this._createdThread!;
+
     public override AgentThread ServiceFailingAgentThread => null!;
 
     public override AgentThread CreatedServiceFailingAgentThread => null!;
@@ -53,7 +56,7 @@ public override Task DeleteThread(AgentThread thread)
         return Task.CompletedTask;
     }
 
-    public override Task InitializeAsync()
+    public async override Task InitializeAsync()
     {
         AzureOpenAIConfiguration configuration = this._configuration.GetSection("AzureOpenAI").Get<AzureOpenAIConfiguration>()!;
 
@@ -70,7 +73,7 @@ public override Task InitializeAsync()
             Instructions = "You are a helpful assistant.",
         };
         this._thread = new ChatHistoryAgentThread();
-
-        return Task.CompletedTask;
+        this._createdThread = new ChatHistoryAgentThread();
+        await this._createdThread.CreateAsync();
     }
 }

dotnet/src/IntegrationTests/Agents/CommonInterfaceConformance/OpenAIAssistantAgentFixture.cs

@@ -30,13 +30,16 @@ public class OpenAIAssistantAgentFixture : AgentFixture
     private Assistant? _assistant;
     private OpenAIAssistantAgent? _agent;
     private OpenAIAssistantAgentThread? _thread;
+    private OpenAIAssistantAgentThread? _createdThread;
     private OpenAIAssistantAgentThread? _serviceFailingAgentThread;
     private OpenAIAssistantAgentThread? _createdServiceFailingAgentThread;
 
     public override Agent Agent => this._agent!;
 
     public override AgentThread AgentThread => this._thread!;
 
+    public override AgentThread CreatedAgentThread => this._createdThread!;
+
     public override AgentThread ServiceFailingAgentThread => this._serviceFailingAgentThread!;
 
     public override AgentThread CreatedServiceFailingAgentThread => this._createdServiceFailingAgentThread!;
@@ -64,6 +67,14 @@ public override async Task DisposeAsync()
             }
         }
 
+        try
+        {
+            await this._assistantClient!.DeleteThreadAsync(this._createdThread!.Id);
+        }
+        catch (ClientResultException ex) when (ex.Status == 404)
+        {
+        }
+
         await this._assistantClient!.DeleteAssistantAsync(this._assistant!.Id);
     }
 
@@ -90,6 +101,9 @@ await this._assistantClient.CreateAssistantAsync(
         this._agent = new OpenAIAssistantAgent(this._assistant, this._assistantClient) { Kernel = kernel };
         this._thread = new OpenAIAssistantAgentThread(this._assistantClient);
 
+        this._createdThread = new OpenAIAssistantAgentThread(this._assistantClient);
+        await this._createdThread.CreateAsync();
+
         var serviceFailingClient = OpenAIAssistantAgent.CreateAzureOpenAIClient(new AzureCliCredential(), new Uri("https://localhost/failingserviceclient"));
         this._serviceFailingAgentThread = new OpenAIAssistantAgentThread(serviceFailingClient.GetAssistantClient());