Skip to content

.Net: Add a common agent invoke api. #11069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 21, 2025

Conversation

westey-m
Copy link
Contributor

Motivation and Context

Being able to different invoke agents using a common API is useful to build higher level code on top of.

Description

Adding a common Invoke method with a common Thread object.

Contribution Checklist

@markwallace-microsoft markwallace-microsoft added the .NET Issue or Pull requests regarding .NET code label Mar 19, 2025
@github-actions github-actions bot changed the title Add a common agent invoke api. .Net: Add a common agent invoke api. Mar 19, 2025
Fix kernel and arguments override capability
Add helper for common thread validation
@markwallace-microsoft markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Mar 21, 2025
/// <inheritdoc />
public override async Task<string> StartAsync(CancellationToken cancellationToken = default)
{
if (this._isActive)
Copy link
Member

@alliscode alliscode Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be idempotent and just return the current thread Id in this case instead of throwing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be idempotent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update in next PR.

@westey-m westey-m changed the base branch from main to feature-common-agent-api March 21, 2025 19:14
@westey-m westey-m marked this pull request as ready for review March 21, 2025 19:19
@westey-m westey-m requested a review from a team as a code owner March 21, 2025 19:19
@westey-m westey-m merged commit 2eeaa5e into microsoft:feature-common-agent-api Mar 21, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants