.Net: Changes to support .NET9 formatting #10838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
ross-p-smith
force-pushed
the
ross/sdk9-format
branch
from
7e51302 to
fc89faa
Compare
ross-p-smith
force-pushed
the
ross/sdk9-format
branch
from
fc89faa to
ffe717f
Compare
markwallace-microsoft
approved these changes
Mar 7, 2025
SergeyMenshykh
approved these changes
Mar 7, 2025
|
This PR description doesn't describe what its doing.. |
markwallace-microsoft
changed the title
markwallace-microsoft
changed the title
musale
pushed a commit
to musale/semantic-kernel
that referenced
this pull request
Mar 10, 2025
### Motivation and Context In sdk9, there is a bug fix to one of the analyzers: [https://github.com/dotnet/msbuild/issues/11426](https://github.com/dotnet/msbuild/issues/11426). This causes the code base to fail in the `dotnet format` stage when built on sdk9. This PR fixes the file that has been changed this week and adds a configuration into the build to format using sdk9.0 so that the build fails if more are introduced. - [x] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 This relates to microsoft#10716 and was previously fixed in microsoft#10741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In sdk9, there is a bug fix to one of the analyzers: dotnet/roslyn#78295. This causes the code base to fail in the
dotnet formatstage when built on sdk9.This PR fixes the file that has been changed this week and adds a configuration into the build to format using sdk9.0 so that the build fails if more are introduced.
This relates to dotnet/msbuild#10716 and was previously fixed in dotnet/msbuild#10741