-
Notifications
You must be signed in to change notification settings - Fork 4k
Python: Introducing the Faiss Connector #10810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python Test Coverage Report •
Python Unit Test Overview
|
c6c678d
to
22306a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR introduces a new Faiss connector for semantic-kernel, including implementations for FaissCollection and FaissStore along with comprehensive unit tests and sample usage updates.
- Adds FaissCollection and FaissStore classes to integrate Faiss as an in-memory similarity search engine.
- Updates tests, configuration (pyproject.toml), and sample usage to support the new Faiss connector.
Reviewed Changes
File | Description |
---|---|
python/tests/unit/connectors/memory/faiss/test_faiss.py | Adds unit tests for Faiss functionality. |
python/semantic_kernel/connectors/memory/faiss.py | Implements the FaissCollection and FaissStore classes. |
python/tests/conftest.py | Updates import for Kernel initialization. |
python/pyproject.toml | Adds dependency for faiss-cpu. |
python/samples/concepts/memory/complex_memory.py | Integrates FaissCollection into sample usage. |
python/semantic_kernel/connectors/memory/in_memory/in_memory_collection.py | Refines generic types for in-memory collections. |
python/semantic_kernel/data/vector_storage/vector_store.py | Minor type annotations update. |
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
TaoChenOSU
approved these changes
Mar 10, 2025
moonbox3
approved these changes
Mar 11, 2025
moonbox3
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds a FaissVectorStore and FaissCollection
Faiss is a really fast similarity search engine, which runs in memory.
You can also use GPU's with it, but you will have to build the package yourself.
Description
Closes #4130
TODO:
Contribution Checklist