Skip to content

Python: set openai package to newer version and removed default value of parallel tool calls #10502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

eavanvalkenburg
Copy link
Member

Motivation and Context

We noticed that the openai package dependency spec was off and did not update that when present to the newest version, fixed now.
Also we mistakenly had a default value for parallel_tool_calls in our prompt executions settings, as with other settings we do not maintain a default value if the API has a default and in this case having that parameter when calling a reasoning model threw an error, fixed here.

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner February 12, 2025 10:01
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Feb 12, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Feb 12, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/connectors/ai/open_ai/prompt_execution_settings
   open_ai_prompt_execution_settings.py84298%119, 133
TOTAL18530216988% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3174 4 💤 0 ❌ 0 🔥 1m 42s ⏱️

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Feb 12, 2025
Merged via the queue into microsoft:main with commit 9d5ad78 Feb 12, 2025
27 checks passed
@eavanvalkenburg eavanvalkenburg deleted the openai_fix branch February 12, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants