Skip to content

.Net: Removed Obsolete VolatileVectorStore and references. #10494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 13, 2025

Conversation

shethaadit
Copy link
Contributor

Motivation and Context

Removed Obsolete VolatileVectorStore and references for clean code.

Fixes #10472

@shethaadit shethaadit requested a review from a team as a code owner February 11, 2025 22:33
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Feb 11, 2025
@github-actions github-actions bot changed the title Removed Obsolete VolatileVectorStore and references. .Net: Removed Obsolete VolatileVectorStore and references. Feb 11, 2025
@westey-m
Copy link
Contributor

@shethaadit, thanks for the contribution!
Looks like we can delete some of the model classes from KernelBuilderExtensionsTests as well, since they are not in use anymore. See the failing dotnet-format job

@shethaadit
Copy link
Contributor Author

@shethaadit, thanks for the contribution! Looks like we can delete some of the model classes from KernelBuilderExtensionsTests as well, since they are not in use anymore. See the failing dotnet-format job

Hi @westey-m, Thank you for your comments. I have updated it.

@westey-m
Copy link
Contributor

@shethaadit, you probably saw there was an error during the CI build. The reason for this error is that the change we are making here is a breaking change. We have checks in place to avoid making breaking changes accidentally. Since we are deliberately making a breaking change here though, we can update a suppression file to work around it.

To do so, just run the following command from the dotnet folder of this repo:
dotnet build --configuration Release /p:GenerateCompatibilitySuppressionFile=true

This will update the required suppression files. Push the updates to those files, and the build should then pass.

Thanks again for helping out!

@shethaadit
Copy link
Contributor Author

dotnet build --configuration Release /p:GenerateCompatibilitySuppressionFile=true

Hi @westey-m, Thank you for your guidance, I tried that but build still fails.

\semantic-kernel\dotnet>dotnet build --configuration Release /p:GenerateCompatibilitySuppressionFile=true
Restore complete (4.4s)
  kernel-functions-generator succeeded (8.6s) → samples\Demos\CreateChatGptPlugin\MathPlugin\kernel-functions-generator\bin\Release\netstandard2.0\kernel-functions-generator.dll
  VectorData.Abstractions netstandard2.0 succeeded (12.6s) → src\Connectors\VectorData.Abstractions\bin\Release\netstandard2.0\Microsoft.Extensions.VectorData.Abstractions.dll
  VectorData.Abstractions net8.0 succeeded (13.1s) → src\Connectors\VectorData.Abstractions\bin\Release\net8.0\Microsoft.Extensions.VectorData.Abstractions.dll
  SemanticKernel.Abstractions net8.0 failed with 1 error(s) (6.4s) → src\SemanticKernel.Abstractions\bin\Release\net8.0\Microsoft.SemanticKernel.Abstractions.dll
    E:\Open-Source\semantic-kernel\dotnet\Directory.Build.targets(11,5): error MSB3073: The command "dotnet format --no-restore -v diag SemanticKernel.Abstractions.csproj" exited with code 1.
  SemanticKernel.Abstractions netstandard2.0 failed with 1 error(s) (6.9s) → src\SemanticKernel.Abstractions\bin\Release\netstandard2.0\Microsoft.SemanticKernel.Abstractions.dll
    E:\Open-Source\semantic-kernel\dotnet\Directory.Build.targets(11,5): error MSB3073: The command "dotnet format --no-restore -v diag SemanticKernel.Abstractions.csproj" exited with code 1.
  VectorData.Abstractions net462 succeeded (10.7s) → src\Connectors\VectorData.Abstractions\bin\Release\net462\Microsoft.Extensions.VectorData.Abstractions.dll

Build failed with 2 error(s) in 40.0s

could you please help pushing changes?

@dmytrostruk dmytrostruk added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@dmytrostruk dmytrostruk added this pull request to the merge queue Feb 13, 2025
Merged via the queue into microsoft:main with commit 1e08663 Feb 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.Net: Remove obsolete VolatileVectorStore
4 participants