-
Notifications
You must be signed in to change notification settings - Fork 4k
.Net: Removed Obsolete VolatileVectorStore and references. #10494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Removed Obsolete VolatileVectorStore and references. #10494
Conversation
@shethaadit, thanks for the contribution! |
Hi @westey-m, Thank you for your comments. I have updated it. |
@shethaadit, you probably saw there was an error during the CI build. The reason for this error is that the change we are making here is a breaking change. We have checks in place to avoid making breaking changes accidentally. Since we are deliberately making a breaking change here though, we can update a suppression file to work around it. To do so, just run the following command from the dotnet folder of this repo: This will update the required suppression files. Push the updates to those files, and the build should then pass. Thanks again for helping out! |
…into shethaadit/FixBug10472
…t/semantic-kernel into shethaadit/FixBug10472
Hi @westey-m, Thank you for your guidance, I tried that but build still fails. \semantic-kernel\dotnet>dotnet build --configuration Release /p:GenerateCompatibilitySuppressionFile=true
Restore complete (4.4s)
kernel-functions-generator succeeded (8.6s) → samples\Demos\CreateChatGptPlugin\MathPlugin\kernel-functions-generator\bin\Release\netstandard2.0\kernel-functions-generator.dll
VectorData.Abstractions netstandard2.0 succeeded (12.6s) → src\Connectors\VectorData.Abstractions\bin\Release\netstandard2.0\Microsoft.Extensions.VectorData.Abstractions.dll
VectorData.Abstractions net8.0 succeeded (13.1s) → src\Connectors\VectorData.Abstractions\bin\Release\net8.0\Microsoft.Extensions.VectorData.Abstractions.dll
SemanticKernel.Abstractions net8.0 failed with 1 error(s) (6.4s) → src\SemanticKernel.Abstractions\bin\Release\net8.0\Microsoft.SemanticKernel.Abstractions.dll
E:\Open-Source\semantic-kernel\dotnet\Directory.Build.targets(11,5): error MSB3073: The command "dotnet format --no-restore -v diag SemanticKernel.Abstractions.csproj" exited with code 1.
SemanticKernel.Abstractions netstandard2.0 failed with 1 error(s) (6.9s) → src\SemanticKernel.Abstractions\bin\Release\netstandard2.0\Microsoft.SemanticKernel.Abstractions.dll
E:\Open-Source\semantic-kernel\dotnet\Directory.Build.targets(11,5): error MSB3073: The command "dotnet format --no-restore -v diag SemanticKernel.Abstractions.csproj" exited with code 1.
VectorData.Abstractions net462 succeeded (10.7s) → src\Connectors\VectorData.Abstractions\bin\Release\net462\Microsoft.Extensions.VectorData.Abstractions.dll
Build failed with 2 error(s) in 40.0s could you please help pushing changes? |
Motivation and Context
Removed Obsolete VolatileVectorStore and references for clean code.
Fixes #10472