Python: .Net: ADR for realtime #10355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

eavanvalkenburg merged 17 commits into microsoft:main from eavanvalkenburg:realtime_adr

Feb 18, 2025

Member

eavanvalkenburg commented Jan 31, 2025

Motivation and Context

ADR describing the preliminary design for realtime API's.
As these API's themselves are in preview, we might have to deal with incompatible changes down the road.

Description

Contribution Checklist

The code builds clean without any errors or warnings
The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
All unit tests pass, and I have added new tests where possible
I didn't break anyone 😄

markwallace-microsoft added the documentation label

eavanvalkenburg force-pushed the realtime_adr branch from 37648e7 to c83fedd Compare

January 31, 2025 14:50

eavanvalkenburg enabled auto-merge

January 31, 2025 14:50

eavanvalkenburg mentioned this pull request

.Net: Python: Realtime API #10073

Open

5 tasks

TaoChenOSU reviewed

View reviewed changes

docs/decisions/0064-realtime-api-clients.md Outdated Show resolved Hide resolved

TaoChenOSU reviewed

View reviewed changes

docs/decisions/0064-realtime-api-clients.md Outdated Show resolved Hide resolved

TaoChenOSU reviewed

View reviewed changes

docs/decisions/0064-realtime-api-clients.md Outdated Show resolved Hide resolved

TaoChenOSU reviewed

View reviewed changes

docs/decisions/0064-realtime-api-clients.md Outdated Show resolved Hide resolved

TaoChenOSU reviewed

View reviewed changes

docs/decisions/0064-realtime-api-clients.md Outdated Show resolved Hide resolved

eavanvalkenburg force-pushed the realtime_adr branch from 9d56798 to d416016 Compare

February 1, 2025 14:20

eavanvalkenburg force-pushed the realtime_adr branch from d416016 to ace06eb Compare

February 10, 2025 09:51

eavanvalkenburg added .NET python labels

github-actions bot changed the title ~~ADR for realtime~~ Python: ADR for realtime

github-actions bot changed the title ~~Python: ADR for realtime~~ .Net: ADR for realtime

eavanvalkenburg force-pushed the realtime_adr branch from ace06eb to 7560b88 Compare

February 11, 2025 07:57

markwallace-microsoft removed .NET python labels

eavanvalkenburg added the python label

github-actions bot changed the title ~~.Net: ADR for realtime~~ Python: .Net: ADR for realtime

markwallace-microsoft removed the python label

eavanvalkenburg force-pushed the realtime_adr branch 3 times, most recently from afa206e to 30e4b81 Compare

February 12, 2025 13:14

westey-m reviewed

View reviewed changes

docs/decisions/0065-realtime-api-clients.md Outdated Show resolved Hide resolved

westey-m reviewed

View reviewed changes

docs/decisions/0065-realtime-api-clients.md Show resolved Hide resolved

westey-m reviewed

View reviewed changes

docs/decisions/0065-realtime-api-clients.md Outdated Show resolved Hide resolved

RogerBarreto reviewed

View reviewed changes

docs/decisions/0065-realtime-api-clients.md Show resolved Hide resolved

eavanvalkenburg force-pushed the realtime_adr branch from 5c3938f to deba679 Compare

February 12, 2025 17:04

westey-m reviewed

View reviewed changes

docs/decisions/0065-realtime-api-clients.md Outdated Show resolved Hide resolved

eavanvalkenburg force-pushed the realtime_adr branch from 6e7b364 to a4e9dbf Compare

February 17, 2025 14:32

eavanvalkenburg added 17 commits

February 18, 2025 09:17


          ADR for realtime

964bf2c


          addressed comments

d84a161


          updated number

9e70ed6


          replaced openai link

f73dc98


          small updates to the text

8c27898


          small updates to ADR

d364b77


          renamed events and added transcript json

f077e4a


          skip spellcheck on json

4ff575f


          fix typos

69bf7c8


          fixed typos

b1ae12f


          added note

14c5b35


          typo fix

f2d5e21


          another typo

727997f


          naming changes from feedback

abb3ee4


          change to service_event

c0713b6


          small text update

015ff94


          added RealtimeEvent class

c34269c

eavanvalkenburg force-pushed the realtime_adr branch from a4e9dbf to c34269c Compare

February 18, 2025 08:17

westey-m approved these changes

View reviewed changes

markwallace-microsoft approved these changes

View reviewed changes

Member

markwallace-microsoft left a comment

LGTM, you can change the status as proposed as this may change as new real-time services come online

eavanvalkenburg added this pull request to the merge queue

Merged via the queue into microsoft:main with commit ffacc04

16 checks passed

eavanvalkenburg deleted the realtime_adr branch

February 18, 2025 16:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

TaoChenOSU TaoChenOSU left review comments

dmytrostruk dmytrostruk left review comments

RogerBarreto RogerBarreto left review comments

markwallace-microsoft markwallace-microsoft approved these changes

westey-m westey-m approved these changes

Labels