[heft] Fix Heft-Jest-Plugin schema to match with configuration options #5097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlliMartin
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
|
@microsoft-github-policy-service agree |
D4N14L
reviewed
Feb 6, 2025
heft-plugins/heft-jest-plugin/src/schemas/heft-jest-plugin.schema.json
Outdated
Show resolved
Hide resolved
heft-plugins/heft-jest-plugin/src/schemas/heft-jest-plugin.schema.json
Outdated
Show resolved
Hide resolved
D4N14L
approved these changes
Feb 6, 2025
octogonz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a mismatch between the schema and the possible configuration documented here.
This PR extends the schema to match the plugin options.
Details
Extended the schema, mostly with information already available in the documentation.
Note that both
debugHeftReporteranddetectOpenHandleswere not added to the schema on purpose, since IMO they do not belong in something that is set up statically (but should only be passed from the command line)Happy to adjust that, if wanted.
How it was tested
I modified the schema json in one of my projects consuming rush (within node_modules) and verified the behaviour.
Impacted documentation
None; This PR aligns the code to the documentation.