[webpack5-localization-plugin] Streamline processing #5095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
TheLarkInn
as code owners
dmichon-msft
commented
Feb 5, 2025
iclanton
approved these changes
Feb 5, 2025
dmichon-msft
commented
Feb 14, 2025
| @@ -91,6 +143,8 @@ export function processLocalizedAsset(options: IProcessLocalizedAssetOptions): R | |||
| const localizedFiles: Record<string, string> = {}; | |||
| (chunk as ILocalizedWebpackChunk).localizedFiles = localizedFiles; | |||
There was a problem hiding this comment.
This line needs to happen outside of the caching call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5093
Details
Leverages webpack's caching layer for the localized asset processing.
Currently does not add caching for trueHash computation, that'll need its own PR since it's a bit more complex.
Splits the placeholder map into two layers: a map of keys to files, then string names to placeholders. This facilitates creating fewer intermediary objects and thereby reducing memory pressure and the amount of data processing needed.
Stops parsing non-localized chunks that aren't known to contain placeholders.
How it was tested
Unit tests to ensure functionality didn't regress.
Running against an external project to validate performance impact.
Impacted documentation
API documentation for removed access to internals.