[rush] Fix the issue of accessing shouldEnsureConsistentVersions method incorrectly.

[fzxen]

Summary

Rush version command throws the following error where I had set ensureConsistentVersions to false in my rush repo.

ERROR: Unable to finish version bump because inconsistencies were encountered. Run "rush check" to find more details.

Details

shouldEnsureConsistentVersions is a function not a variable.

rushstack/libraries/rush-lib/src/api/Subspace.ts

Lines 328 to 335 in 7aa7b9f

	public shouldEnsureConsistentVersions(variant?: string): boolean {
	// If the subspaces feature is enabled, or the ensureConsistentVersions field is defined, return the value of the field
	if (this._rushConfiguration.subspacesFeatureEnabled) {
	const commonVersions: CommonVersionsConfiguration = this.getCommonVersions(variant);
	if (commonVersions.ensureConsistentVersions !== undefined) {
	return commonVersions.ensureConsistentVersions;
	}
	}

Therefore, the condition expression here is always true.

rushstack/libraries/rush-lib/src/cli/actions/VersionAction.ts

Lines 219 to 221 in 7aa7b9f

	if (!subspace.shouldEnsureConsistentVersions) {
	return;
	}

This issue is introduced by #4927

How it was tested

no-unnecessary-condition may help us permanently avoid this problem.

Impacted documentation

[dmichon-msft]

Almost there.

[octogonz]

@fzxen Thanks for fixing this!