[rush] Fix an issue where incremental building (with LegacySkipPlugin) would not work when no-op operations were present in the process #4993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
witcher112
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
dmichon-msft
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In our project we have a several packages that are "buildless" and we enable "ignoreMissingScript" for build command through command-line.json (we don't use phased commands).
After upgrading to latest version of Rush, I discovered that incremental building stopped working in random scenarios.
Details
I've tracked down the issue to LegacySkipPlugin beforeExecuteOperations hook. Turns out that "for" loop inside that hook used "return" statements instead of "continue" to skip registering operations as incremental. I've replaced all of them and verified that fix is working.
How it was tested
Tested on repository with multiple "no-op" build packages.
Impacted documentation