Skip to content

[rush] Fix logging for non-zero exit codes #4984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

dmichon-msft
Copy link
Contributor

@dmichon-msft dmichon-msft commented Oct 29, 2024

Summary

Fixes #4882

Child process that only writes to stdout but is configured to exit with code 2.
Before:
image
After:
image

Details

With this change, Rush internally writes any fatal error from an Operation to the stderr stream of the StdioSummarizer instead of the stdout stream. This effectively makes the error seen by Rush be treated as lower priority for the logs than any stderr output from the Operation itself.

How it was tested

Added process.exitCode = 2 to the end of the build script in api-extractor-lib1-test.

Impacted documentation

Anything about the error reporting for non-zero exit codes.

@octogonz octogonz enabled auto-merge (squash) October 29, 2024 00:55
@octogonz octogonz merged commit cc10df7 into microsoft:main Oct 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

[rush] rush build error logs no longer include stdout
3 participants