-
Notifications
You must be signed in to change notification settings - Fork 631
[heft-storybook-plugin] feat: storybook v8 support #4971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[heft-storybook-plugin] feat: storybook v8 support #4971
Conversation
Also adds new parameter to use the new test build mode in Storybook v8
bd24667
to
ada6434
Compare
This leaves the "Storybook failed to check addon compatibility" warning
I'm not sure the best way to work around this with the plugin. Storybook will accept an I'm not clear what this is for either, I'm just aiming to get rid of the warning. Looking at references to the getPackageManager method it seems to be things like adding/removing addons, upgrading and something about a "sandbox" which I have to assume probably won't work well in a Rush monorepo anyway even if it knows what package manager to use. Quite frankly I'm unclear why Storybook logs the message at all. It should fall back to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more quick thing.
Head branch was pushed to by a user without write access
Also adds new parameter to use the new test build mode in Storybook v8
Summary
Adds a new cliCallingConvention for Storybook v8
Adds a new
--storybook-test
flag parameter to enable the--test
storybook build flagFixes #4964
Details
How it was tested
Linked into our monorepo
Built a v8 storybook with/without
--storybook-test
flag and verified that running a watch build with--storybook-test
throws an errorImpacted documentation