Skip to content

[workspace-resolve] Fix cross-package import #4908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024
+13 −1
Merged

[workspace-resolve] Fix cross-package import #4908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...s/@rushstack/webpack-workspace-resolve-plugin/fix-workspace-resolve_2024-08-28-22-55.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@rushstack/webpack-workspace-resolve-plugin",
"comment": "Fix description file resolution after cross-package import.",
"type": "patch"
}
],
"packageName": "@rushstack/webpack-workspace-resolve-plugin"
}
4 changes: 3 additions & 1 deletion webpack/webpack-workspace-resolve-plugin/src/WorkspaceResolvePlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ export class WorkspaceResolvePlugin implements WebpackPluginInstance {
new KnownDescriptionFilePlugin(cache, 'parsed-resolve', 'described-resolve'),
// Optimize locating the installed dependencies of the current package
new KnownPackageDependenciesPlugin(cache, 'raw-module', 'resolve-as-module'),
// Optimize loading the package.json file for the destination package
// Optimize loading the package.json file for the destination package (bare specifier)
new KnownDescriptionFilePlugin(cache, 'resolve-as-module', 'resolve-in-package'),
// Optimize loading the package.json file for the destination package (relative path)
new KnownDescriptionFilePlugin(cache, 'relative', 'described-relative'),
// Optimize locating and loading nested package.json for a directory
new KnownDescriptionFilePlugin(cache, 'undescribed-existing-directory', 'existing-directory', true),
Expand Down
Loading