Extract LookupByPath -> @rushstack/lookup-by-path #4868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
patmill
as code owners
|
I'm okay with this, however... despite being "standard" among academics, I find the name "trie" to be annoying because its pronunciation is confusingly identical to "tree". This jargon will be unfamiliar to most engineers, which may hinder adoption. The other common name "prefix tree" is much more intuitive, but the name doesn't /have/ to be the implementation. If instead we name the usage/purpose, the name could be like "PathLookup" etc |
|
Oh hey, LookupByPath is pretty good 😄 |
dmichon-msft
changed the title
D4N14L
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the
LookupByPathclass into its own package,@rushstack/lookup-by-path.Renames the class to
PathTrieto reflect the standard computer science name for the structure.The motivation for this PR is to be able to reuse this class in the upcoming
@rushstack/webpack-workspace-resolve-plugin, or in other packages that cannot take a dependency on@microsoft/rush-libor@rushstack/rush-sdk.Details
Removes the ability to deep import
@microsoft/rush-lib/lib/logic/LookupByPath.How it was tested
Unit tests.
Impacted documentation
API spec.