[rush-lib] Don't interrupt the installation process if the user hasn't enabled the inject dependencies feature. #4830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-Qun
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
L-Qun
changed the title
jzhang026
reviewed
Jul 11, 2024
…f it is not used when run update
octogonz
approved these changes
Jul 12, 2024
|
🚀 Finally released with Rush 5.129.7, thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Yesterday, we received an on-call stating that a user experienced a failure in the CI installation process, even after executing
rush update.After investigating, we discovered that the
repo-state.jsonfile includes thepackageJsonInjectedDependenciesHash, butalwaysInjectDependenciesFromOtherSubspacesis not enabled.We believe this error negatively impacts the user experience. Users do not know how to resolve the issue after receiving the error message. So, we made a small modification to the source code:
I think a better way is to give a warning without interrupting the installation process.
How it was tested
alwaysInjectDependenciesFromOtherSubspacesfrom thepnpm-config.jsonfile.rush update.rush install.Impacted documentation
None.