[rush] Fix an issue where rush add always adds the latest version if ensureConsistentVersions is set in rush.json.
#4828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
|
@william2958 FYI |
octogonz
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4826
Details
The code that determines which version to add uses the
ensureConsistentVersionsproperty from the object that is constructed from thecommon-versions.jsonfile. This was introduced in #4735. This issue was caused by a missed case - theensureConsistentVersionsproperty ofrushConfigurationis marked as@deprecated, but its value wasn't plumbed into theCommonVersionsConfigurationobject. This PR uses therush.jsonvalue if a value wasn't provided incommon-versions.jsonHow it was tested
Tested in a repo with a repro, and added unit tests for the
CommonVersionsConfigurationchange.Impacted documentation
None.