[rush-lib] Supports the rush install-autoinstaller command #4823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-Qun
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
L-Qun
changed the title
L-Qun
changed the title
L-Qun
changed the title
iclanton
reviewed
Jul 10, 2024
libraries/rush-lib/src/cli/actions/InstallAutoinstallerAction.ts
Outdated
Show resolved
Hide resolved
libraries/rush-lib/src/cli/actions/InstallAutoinstallerAction.ts
Outdated
Show resolved
Hide resolved
libraries/rush-lib/src/cli/actions/InstallAutoinstallerAction.ts
Outdated
Show resolved
Hide resolved
iclanton
reviewed
Jul 10, 2024
common/changes/@microsoft/rush/feat-install-autoinstaller_2024-07-04-13-25.json
Outdated
Show resolved
Hide resolved
iclanton
reviewed
Jul 16, 2024
libraries/rush-lib/src/cli/actions/InstallAutoinstallerAction.ts
Outdated
Show resolved
Hide resolved
|
Thanks to @iclanton, I learned a lot about coding practices! |
|
Hi @iclanton, all your comments have been resolved, can you take another look at this PR? |
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
…-07-04-13-25.json Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
iclanton
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Supports the
rush install-autoinstallercommand to prevent accidental updates to the lockfile.Exports
AutoinstallerandRushGlobalFolderclass for easy use in business scenarios leveraging the rush-sdk.How it was tested
Manually tested with Rushstack repo locally.
Impacted documentation
microsoft/rushstack-websites#233