[rush] Fix an edge case for workspace peer dependencies when calculating packageJsonInjectedDependenciesHash to improve its accuracy #4809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-chao
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
patmill
as code owners
D4N14L
previously requested changes
Jun 26, 2024
g-chao
force-pushed
the
chao/improve-getPackageJsonInjectedDependenciesHash
branch
from
9846523 to
034bea6
Compare
g-chao
changed the title
octogonz
approved these changes
Jun 26, 2024
octogonz
dismissed
D4N14L’s stale review
That issue has been addressed in the latest commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If you declare a workspace package in peerDependencies, though you put the version range there, PNPM does not respect it. Below is an example:
peerDependencies section in
@rushstack/heft-api-extractor-pluginproject package.jsonThe actual
pnpm-lock.yamlSo, we don't need to take these packages into consideration when calculating packageJsonInjectedDependenciesHash.
How it was tested
Manually tested with Monorepo locally.