Add global shortcuts to improve keyboard navigation #10551
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-robert
force-pushed
the
global-shortcuts
branch
from
08c635b to
0ab918f
Compare
microbit-robert
force-pushed
the
global-shortcuts
branch
from
0ab918f to
9e1880b
Compare
I personally prefer what is currently implemented, i.e. region 1 starts with the editor toggle, not the skip links. I view the value of this global navigation to be quicker navigation throughout a coding session, and the skip links as mainly being valuable on first arrival. Most of the skip links are available within a couple of tabs anyway. The most valuable skip link for me is the "jump to Blocks workspace" when you have just arrived. If you've just triggered the global navigation overlay then you don't need it! |
Adds Ctrl/Cmd+B shortcut that shows a numbered navigation overlay. Integrates with a pxt-microbit change that propagates global-nav actions from the simulator (otherwise they don't take effect when the iframe has focus). Co-authored-by: Grace <145345672+microbit-grace@users.noreply.github.com>
microbit-matt-hillsdon
force-pushed
the
global-shortcuts
branch
from
a7670af to
248e903
Compare
|
Closing in favour of alternative PR. |
|
Replaced by #10570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See microsoft/pxt-microbit#6151. We've moved to an approach where Ctrl-U shows an overlay with navigable regions labelled by number in an effort to move forward with this after some recent discussion.
See accompanying change in
pxt-microbitwhich ensures that global shortcuts are also enabled when focus is inside the simulator iframe (e.g., simulator buttons, etc).Link to demo. Please note that 'accessible blocks' need to be set to 'on' in the settings menu. Use Ctrl-U to show the navigation overlay, and then a number to move to that region. Ctrl-U is a shortcut to view the page source code which feels like a seldom used shortcut and one we can safely override.
Issues to fix:
@microbit-matt-hillsdon