CI: Update testghpkgs workflow to be able to run it again. #5754
Conversation
| node-version: [8.x] | ||
| branch: [stable3.0] |
There was a problem hiding this comment.
Rather than have the branch in the yaml file, I've added it as a workflow form input, so that it can be set to whatever it's needed at the point the workflow is manually triggered:
| branch-or-commit: | ||
| description: Branch or commit to checkout for test | ||
| required: false | ||
| default: 'master' |
There was a problem hiding this comment.
I've set the default to the main branch, the workflow has testing on stable3, so if needed we could change this to one of the stable branches.
However, since the form has to be triggered manually, I think it's probably fine to input that at the time it's triggered.
|
I'm manually triggered this workflow and it's currently running agains the |
|
@abchatra this is running correctly, so it's ready to be reviewed. |
|
@riknoll to review |
|
@carlosperate is this still relevant? |
|
Yes, I think so, as running the workflow last year when I submitted the PR had already discovered a few broken extensions. This can also be useful to check we haven't accidentally broken any extensions (via MakeCode or CODAL changes) before a major release. If I remember correctly It does take a significant amount of time to run to completion, and so it timed out a couple of times, but because it caches the build results it was able to continue where it left off. |
It's been a while since this workflow was run, so it needed some minor updates.