sparse_mmap: support safe volatile access methods (#1499) #1670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add methods on `SparseMapping` that call `try_read_volatile` and `try_write_volatile`. This makes it easy and safe to access a mapping with volatile semantics, needed to access device registers, for example.
|
I'm not sure this is needed if nothing in 2505 is using these new methods yet. |
|
@smalis-msft I think we are going to hold off on this one and #1671 until @jstarks finishes some more changes that we will be pulling back to release/2505. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods on
SparseMappingthat calltry_read_volatileandtry_write_volatile. This makes it easy and safe to access a mapping with volatile semantics, needed to access device registers, for example.Cherry-pick of #1499