virt_whp: add support for MMIO hypercalls #1578
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support MMIO hypercalls from VTL2, but don't advertise this capability yet. This is currently just useful for private testing, but it provides the infrastructure to implement this in other places (e.g., virt_mshv_vtl).
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for MMIO hypercalls for VTL2 testing, laying the groundwork to extend this support to other components.
- Introduces async handling of hypercalls in both x86 and aarch64 processors.
- Implements a new PendingHypercall enum to support asynchronous MMIO read and write operations.
- Updates hypercall dispatch and support functions across several hypervisor modules.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vmm_core/virt_whp/src/vp.rs | Updated async handling for hypercalls in x86 and aarch64 contexts |
| vmm_core/virt_whp/src/hypercalls.rs | Added PendingHypercall enum and new MMIO read/write implementations |
| vm/hv1/hvdef/src/lib.rs | Added conversion implementation from HvResult<()> to HypercallOutput |
| vm/hv1/hv1_hypercall/src/support.rs | Extended AsHandler trait and added hypercall completing helpers |
| vm/hv1/hv1_hypercall/src/lib.rs | Re-exported new hypercall completing helpers |
| vm/hv1/hv1_hypercall/src/imp.rs | Introduced new hypercall implementations for MMIO read/write |
| vm/hv1/hv1_hypercall/src/aarch64.rs | Adjusted instruction pointer advancement behavior in AArch64 |
Comments suppressed due to low confidence (1)
vm/hv1/hv1_hypercall/src/aarch64.rs:93
- [nitpick] Resetting 'self.pre_advanced' without an inline comment can be confusing. Please add a comment clarifying why this flag is reset in this context.
self.pre_advanced = false;
smalis-msft
reviewed
Jun 23, 2025
smalis-msft
reviewed
Jun 23, 2025
smalis-msft
reviewed
Jun 23, 2025
smalis-msft
reviewed
Jun 23, 2025
| @@ -90,6 +90,7 @@ impl<T: Arm64RegisterState> HypercallIo for Arm64RegisterIo<T> { | |||
| if self.pre_advanced { | |||
| let pc = self.inner.pc().wrapping_sub(4); | |||
| self.inner.set_pc(pc); | |||
| self.pre_advanced = false; | |||
There was a problem hiding this comment.
Is there a test we could add that would've caught this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support MMIO hypercalls from VTL2, but don't advertise this capability yet. This is currently just useful for private testing, but it provides the infrastructure to implement this in other places (e.g., virt_mshv_vtl).