-
Notifications
You must be signed in to change notification settings - Fork 160
Xhci DMA buffer Allocation fix #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/202502
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202502 #1539 +/- ##
=================================================
Coverage ? 1.55%
=================================================
Files ? 636
Lines ? 233949
Branches ? 370
=================================================
Hits ? 3649
Misses ? 230287
Partials ? 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
there's some stylistic fixes that'll be needed to upstream this but overall the logic looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Between @berlin-with0ut-return 's changes here and this, I assume we will upstream the changes?
Changes Pool allocations to use the PciIo interface's AllocateBuffer routine
@berlin-with0ut-return's changes have already been upstreamed. However, this PR will also need to be upstreamed, yes. |
Description
Changes Pool allocations to use the PciIo interface's AllocateBuffer routine
DMA buffers should be page aligned and always allocated with the appropriate PciIo interface.
On some platforms, where IoMmu is enabled it is possible that if two allocations occur within the same page, and one gets unmapped via PciIo->Unmap, it will also unmap the other allocated address.
How This Was Tested
Tested on physical arm platform.
Integration Instructions
N/A