[REBASE & FF] BaseTools: Update tools_def for AARCH64 #1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os-d
approved these changes
Mar 25, 2025
VivianNK
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202502 #1313 +/- ##
=============================================
Coverage ? 1.59%
=============================================
Files ? 1408
Lines ? 364700
Branches ? 4570
=============================================
Hits ? 5799
Misses ? 358828
Partials ? 73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Apr 12, 2025
apop5
approved these changes
Apr 14, 2025
makubacki
reviewed
Apr 14, 2025
VivianNK
force-pushed
the
personal/vnowkakeane/aarch64_msvc
branch
from
094c0ad to
bcb6bd9
Compare
6 tasks
os-d
approved these changes
Apr 21, 2025
makubacki
approved these changes
Apr 21, 2025
/WX was added as a build flag and now aarch64 builds fail because of an undocumented linker warning: 4226 Alignment specified exceeds target machine page size. This linker warning has always occured and can be ignored. Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
Alignment needed to be updated to 64 because of a linker warning when building with MSVC. /ALIGN:64 is the minimum alignment for MSVC ARM64, which differs from MSVC x64. This was missed when checking into edk2 because CI isn't run for MSVC ARM64. Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
VivianNK
force-pushed
the
personal/vnowkakeane/aarch64_msvc
branch
from
bcb6bd9 to
1b4a75e
Compare
VivianNK
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update tools def for aarch64 for new 202502 build tools changes.
/WX was added in 202502 as a build flag and now Aarch64 builds
fail. The first failure is because of an undocumented linker warning: 4226 Alignment specified exceeds target machine page size. The second is because the minimum alignment for MSVC ARM64 is 64.
Changes made:
#1164 from BaseLib.lib(CpuBreakpoint.obj) : fatal section 0x1 alignment (64) greater than /ALIGN value. 64 is the minimum alignment for MSVC ARM64, which differs from MSVC x64 and was missed when checking into edk2 because ARM64 MSVC CI isn't ran.How This Was Tested
CI and platform build with aarch64
Integration Instructions
N/A
To be upstreamed to edk2