[Cherry-Pick] StandaloneMmPkg: Disable assert when gMmCommBufferHobGuid not found. #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
kuqin12
approved these changes
Mar 14, 2025
os-d
approved these changes
Mar 14, 2025
makubacki
approved these changes
Mar 14, 2025
|
Can you please include the "(cherry picked from commit ...)" message at the end of the commit? The one that comes from the |
apop5
force-pushed
the
personal/apop5/cherrypickstmmfixaarch64
branch
from
b098219 to
aaaba23
Compare
…d not found. For AARCH64 using StandaloneMmPkg, gMmCommBufferHobGuid will not exist. Aarch64 makes use of their own Root MmiHandler that will get the communication buffer out of a separate buffer, and will call MmiMange directly with the information. For x64, where gMmCommBufferHobGuid is expected to be supplied in the hob list passed to StandaloneCore, if the hob does not exist, print out a debug message describing the failure scenario. Its important to note that a mising gMmCommBufferHobGuid will mean non-root MmiHandlers will not be dispatched in the x64 scenario, but that root MmiHandlers will still be dispatched. Signed-off-by: Aaron Pop <aaronpop@microsoft.com> Co-authored-by: Aaron Pop <aaronpop@microsoft.com> (cherry picked from commit 015c4a3)
apop5
force-pushed
the
personal/apop5/cherrypickstmmfixaarch64
branch
from
6df79f7 to
318eba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
StandaloneMmPkg: Disable assert when gMmCommBufferHobGuid not found.
For AARCH64 using StandaloneMmPkg, gMmCommBufferHobGuid will not exist. Aarch64 makes use of their own Root MmiHandler that will get the communication buffer out of a separate buffer, and will call MmiMange directly with the information.
For x64, where gMmCommBufferHobGuid is expected to be supplied in the hob list passed to StandaloneCore, if the hob does not exist, print out a debug message describing the failure scenario.
Its important to note that a mising gMmCommBufferHobGuid will mean non-root MmiHandlers will not be dispatched in the x64 scenario, but that root MmiHandlers will still be dispatched.
How This Was Tested
Booted SBSA without fix, and system would hang at assert gMmCommBufferHobGuid was not found.
After fix, system was able to boot to Uefi shell and Windows.
Integration Instructions
N/A