Export CustomTSWebWorkerFactory type
#3240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be great if this type could get exported, it would help people to have good type guarantees when authoring custom web worker factories.
.d.tsthis export is not resolved/inlined and this is left behind:which doesn't work in this context because
./tsWorkerdoesn't exist anymore in this context and because exports like this are not permitted within namespaces.I'm not sure what I should tweak here to make it work. Should I tweak something in the build script? Or should I juggle the code around and move required types from
./tsWorkertomonaco.contribution.tsand import them frommonaco.contribution.tsto./tsWorker?