Skip to content

serialize objects to bytes in a JSON compatible way #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 24, 2025

Conversation

GeorgeOG
Copy link
Contributor

serialize objects to bytes in a JSON compatible way

Overview

Before, if an API returned an object which had been deserilised, and a library serialised it to bytes afterwards, that byte string would not be valid json as python's str serialises dictionaries with single quotes.

Related Issue

microsoftgraph/msgraph-sdk-python-core#807

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output

serialize objects to bytes in a JSON compatible way
Copy link

@GeorgeOG GeorgeOG changed the title Update json_parse_node.py serialize objects to bytes in a JSON compatible way Mar 23, 2025
@github-project-automation github-project-automation bot moved this to In Progress 🚧 in Kiota Mar 24, 2025
@rkodev rkodev merged commit a2ec433 into microsoft:main Mar 24, 2025
53 checks passed
@github-project-automation github-project-automation bot moved this from In Progress 🚧 to Done ✔️ in Kiota Mar 24, 2025
@GeorgeOG GeorgeOG deleted the patch-1 branch March 24, 2025 09:29
@baywet
Copy link
Member

baywet commented Mar 24, 2025

@rkodev this should have been squashed with a conventional commit message to trigger the release.
Can you create a new PR with a conventional commit please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants