This repository was archived by the owner on Oct 14, 2024. It is now read-only.
Fix: handle relative redirects that have url.scheme == '' #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing an error The raised error is a false positive: relative urls have scheme == '' which is different from http/https but still valid
musale
reviewed
Aug 12, 2024
Co-authored-by: Musale Martin <martinmshale@gmail.com>
baywet
suggested changes
Aug 12, 2024
|
@microsoft-github-policy-service agree |
baywet
previously approved these changes
Aug 12, 2024
baywet
previously approved these changes
Aug 12, 2024
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet
previously approved these changes
Aug 12, 2024
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet
approved these changes
Aug 12, 2024
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The raised error is a false positive: relative urls have scheme == '' which is different from http/https but still valid
Overview
This PR fixes a bug with relative redirects (in my case from
http:localhost/somethingto/something/) that raise an Exception.Related Issue
Fixes # (issue)
Demo
Optional. Screenshots,
curlexamples, etc.Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Testing Instructions