igvm: don't hardcode CPU extended state subleaves in CPUID page #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hardcoding of CPU extended state subleaves in the CPUID page in the IGVM file. Include only the 0x0 and 0x1 subleaves. For the remaining subleaves, the VMM will query and import only the supported subleaves. Hardcoding some unsupported leaves with zeroes can sometimes lead to the PSP rejecting the CPUID page. One instance we've observed of this is when AVX512 is supported by the hardware the PSP doesn't allow setting zeroes for the corresponding subleaves even if AVX512 is not exposed to the VM. However, the PSP is okay if we just omit those subleaves in our CPUID page. Signed-off-by: Anirudh Rayabharam <anrayabh@microsoft.com>
jinankjain
approved these changes
Nov 11, 2024
|
@MahatiC can you please verify if this does not break any of your existing workflows? |
|
@jinankjain Thanks, will merge this once I do a quick check |
KenGordon
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Please withdraw this. We can’t do it this way. It breaks in some of the circumstances. If you are looking at the problem this tries to solve please talk to me and Takuro. There is a plan to fix the underlying problem and then we need to debug the “proper” scheme involving the CPUID_XF page. There is no point two sets of people doing the same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hardcoding of CPU extended state subleaves in the CPUID page in the IGVM file. Include only the 0x0 and 0x1 subleaves.
For the remaining subleaves, the VMM will query and import only the supported subleaves.
Hardcoding some unsupported leaves with zeroes can sometimes lead to the PSP rejecting the CPUID page. One instance we've observed of this is when AVX512 is supported by the hardware the PSP doesn't allow setting zeroes for the corresponding subleaves even if AVX512 is not exposed to the VM. However, the PSP is okay if we just omit those subleaves in our CPUID page.