[0041] Update triangle hit pos return values for HLSL and DXIL #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm-beanz
reviewed
Oct 14, 2025
There was a problem hiding this comment.
I don't think this is an improvement from the HLSL API perspective. Matrices introduce a bunch of possible implicit conversions that can occur which makes it more likely to allow programmer errors.
Since this isn't semantically a matrix we really should have this be a structure.
damyanp
reviewed
Oct 14, 2025
damyanp
reviewed
Oct 14, 2025
jenatali
force-pushed
the
triangle-hit-pos-update
branch
from
a6341c6 to
872fd68
Compare
llvm-beanz
reviewed
Oct 14, 2025
damyanp
approved these changes
Oct 14, 2025
llvm-beanz
approved these changes
Oct 15, 2025
Co-authored-by: Chris B <beanz@abolishcrlf.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on offline discussion, I think I've been convinced that this is the right way to go. Update the spec language and the open issues.