Array accesses and bounds #634
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds language documenting that out of bounds accesses for arrays is undefined behavior, and that zero-sized arrays are disallowed. This also restricts arrays of unknown size to strictly global resource declarations but allows omitting the array bound if it can be inferred from an initiailzer. Resolves microsoft#141
hekota
reviewed
Sep 11, 2025
llvm-beanz
added a commit
to llvm-beanz/hlsl-specs
that referenced
this pull request
Sep 16, 2025
After the meeting today we seem to have alignment here. I'm going to mark this proposal as under review with PR microsoft#634 as the main review for the spec contribution.
llvm-beanz
added a commit
that referenced
this pull request
Sep 17, 2025
After the meeting today we seem to have alignment here. I'm going to mark this proposal as under review with PR #634 as the main review for the spec contribution.
spall
reviewed
Oct 3, 2025
| \textit{D`} \terminal{[} \textit{N} \terminal{]} \opt{attribute-specifier-seq}\br | ||
| \end{grammar} | ||
|
|
||
| declares an array of \textit{N} \textit{T`}, where \textit{N} is the |
There was a problem hiding this comment.
what is the relationship between T and T'?
| the contained type of an array be a complete type. | ||
| \end{note} | ||
|
|
||
| \p A declarator with an omitted array bound is valid if the when declaring an |
There was a problem hiding this comment.
remove 'if the' before when? or remove 'the when' after if?
|
|
||
| \p A declarator with an omitted array bound is valid if the when declaring an | ||
| object of array type which is not a non-static data member and is initialized | ||
| with an initializer that follows the declarator. In this case the array bound is |
There was a problem hiding this comment.
is this only allowed for global declarations of resource objects? or for all array declarations?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds language documenting that out of bounds accesses for arrays is undefined behavior, and that zero-sized arrays are disallowed.
This also restricts arrays of unknown size to strictly global resource declarations but allows omitting the array bound if it can be inferred from an initiailzer.
Resolves #141