Skip to content

Conversation

anupamachandra
Copy link
Contributor

Updates per feedback in #558

Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we should make sure we get at least one approval from a domain expert (ie not me) before merging this.

Before merging, can you update the PR title / description to be more about the substance of the change rather than it being in response to Tex's feedback please?

@anupamachandra anupamachandra changed the title [0029] Updates to Bound's checking behavior per Tex's feedback [0029] Updates to Bound's checking behavior text: BC done at matrix/vector granularity. Jul 16, 2025
@jenatali
Copy link
Member

If any part of the matrix load is out of bounds then the entire matrix load will return zero.

That sounds like additional test content that needs to be added. Otherwise we should relax the wording to indicate that implementations may return zero from the entire matrix load.

@V-FEXrt
Copy link
Collaborator

V-FEXrt commented Jul 21, 2025

@jenatali IIRC will/must is the correct goal here. I believe there was a request for consistent behavior on OOB access

@jenatali
Copy link
Member

@jenatali IIRC will/must is the correct goal here. I believe there was a request for consistent behavior on OOB access

Got it. Will be a pain to do in WARP but oh well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

6 participants