Remove strategy dicts #2090
Merged
Remove strategy dicts #2090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlonsoGuevara
approved these changes
Oct 10, 2025
gaudyb
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a long-standing internal issue wher strongly-typed configs were mapped into dict[str, Any], so we lost a lot of clarity. All args to internal functions are now strongly typed. I also went through and put much firmer boundaries on the deep internals versus the workflow runners - deep internals always take hydrated and specific params with no assumed defaults now, with the responsibility to hydrate everything from config happening entirely in the workflows.