-
Notifications
You must be signed in to change notification settings - Fork 3k
Cleanup cli #1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Cleanup cli #1127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ag into joshbradley/cleanup-cli
@AlonsoGuevara / @andresmor-ms I moved those functions into the Let me know if there is any other feedback. Otherwise I think this is ready to merge. |
AlonsoGuevara
approved these changes
Sep 13, 2024
3 tasks
opensourcemukul
pushed a commit
to opensourcemukul/graphrag
that referenced
this pull request
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up and further standardizes some of the formatting of the various CLI. It also adds some new safeguards (file and directory existence checks) where appropriate.
There was one bug discovered in the
prompt_tune
module where if--config
and--root
were specified, the correct filepath to the config file would not get used and error out.Checklist