Skip to content

Conversation

jgbradley1
Copy link
Collaborator

@jgbradley1 jgbradley1 commented Sep 12, 2024

Description

This PR cleans up and further standardizes some of the formatting of the various CLI. It also adds some new safeguards (file and directory existence checks) where appropriate.

There was one bug discovered in the prompt_tune module where if --config and --root were specified, the correct filepath to the config file would not get used and error out.

Checklist

  • I have tested these changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation (if necessary).
  • I have added appropriate unit tests (if applicable).

@jgbradley1 jgbradley1 requested review from a team as code owners September 12, 2024 07:05
@jgbradley1
Copy link
Collaborator Author

@AlonsoGuevara / @andresmor-ms I moved those functions into the utils directory. and incorporated more use of some existing Enum classes.

Let me know if there is any other feedback. Otherwise I think this is ready to merge.

@jgbradley1 jgbradley1 merged commit f7f96c3 into main Sep 17, 2024
16 checks passed
@jgbradley1 jgbradley1 deleted the joshbradley/cleanup-cli branch September 17, 2024 05:37
opensourcemukul pushed a commit to opensourcemukul/graphrag that referenced this pull request Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants