Skip to content

build-git-installers: decouple the VS registry settings from the autoupdater #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

build-git-installers: decouple the VS registry settings from the autoupdater #740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/workflows/build-git-installers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,16 @@ jobs:

b=/usr/src/build-extra &&

sed -i -e '/^ *InstallAutoUpdater();$/a\
CustomPostInstall();' \
-e '/^ *UninstallAutoUpdater();$/a\
CustomPostUninstall();' \
$b/installer/install.iss &&
sed -i "# First, find the autoupdater parts in the install/uninstall steps
/if IsComponentInstalled('autoupdate')/{
# slurp in the next two lines, where the call to InstallAutoUpdater()/UninstallAutoUpdater() happens
N
N
# insert the corresponding CustomPostInstall()/CustomPostUninstall() call before that block
s/^\\([ \t]*\\)\(.*\\)\\(Install\\|Uninstall\\)\\(AutoUpdater\\)/\\1CustomPost\\3();\\n\\1\\2\\3\\4/
}" $b/installer/install.iss &&
grep CustomPostInstall $b/installer/install.iss &&
grep CustomPostUninstall $b/installer/install.iss &&

cat >>$b/installer/helpers.inc.iss <<\EOF

Expand Down
Loading