winget-release: fix workflow version parsing #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use the licence URLs pointing at HEAD rather than a specific branch version. This change was made during the 2.47.0.vfs.0.3 release by this PR: microsoft/winget-pkgs#185867 The manual text replacements here are no longer needed. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
When running this workflow from the `release` event the parsing of the tag name from the event object must happen _after_ the object has been loaded, not before! This error eventually results in a bogus value for the `$version` argument that gets passed to `wingetcreate`. Ensure we only access the `$github` variable _after_ we've defined it. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running this workflow from the
releaseevent the parsing of the tag name from the event object must happen after the object has been loaded, not before! This error eventually results in a bogus value for the$versionargument that gets passed towingetcreate. Example: microsoft/winget-pkgs@c05e696#diff-297f752772b92e600a2cba463f006d085a70a0919a5fad6b62fd8f88b135c9eeEnsure we only access the
$githubvariable after we've defined it.Whilst we're in here, also drop some no longer needed parts of the script. We now use the licence URLs pointing at
HEADrather than a specific branch version. This change was made during the 2.47.0.vfs.0.3 release by this PR: microsoft/winget-pkgs#185867