Skip to content

Bump a couple of GitHub Actions versions #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 5, 2024
Merged

Conversation

dscho
Copy link
Member

@dscho dscho commented Sep 5, 2024

I propose this alternative to #684, for several reasons:

  • according to https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/, it is incorrect to bump download-artifact to v4 without also bumping upload-artifact to the same version.
  • bumping it to v4.1.7 instead of v4 would require us to follow the versions in too fine-grained a way, better to just follow v4.
  • there is also a v4 of actions/checkout that we need to use
  • to accommodate microsoft/git's release flow, the changes need to be split into appropriate fixup! commits so that the next time we rebase to a newer upstream version, the changes are folded into the appropriate patches.

This bumps actions/checkout to v4, which uses node 20 according to
https://github.com/actions/checkout/releases/tag/v4.0.0.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This bumps actions/checkout to v4, which uses node 20 according to
https://github.com/actions/checkout/releases/tag/v4.0.0.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This patch bumps the upload-artifact/download-artifact to v4.

This implies a major architectural change according to
https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/
and https://github.com/actions/download-artifact/releases/tag/v4.0.0,
and needs both `upload-artifact` _and_ `download-artifact` to be bumped.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This patch bumps the upload-artifact to v4.

This implies a major architectural change according to
https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/
and https://github.com/actions/upload-artifact/releases/tag/v4.0.0,
and needs both `upload-artifact` _and_ `download-artifact` to be bumped.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This patch bumps the upload-artifact to v4.

This implies a major architectural change according to
https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/
and https://github.com/actions/upload-artifact/releases/tag/v4.0.0,
and needs both `upload-artifact` _and_ `download-artifact` to be bumped.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This patch bumps the download-artifact to v4.

This implies a major architectural change according to
https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/
and https://github.com/actions/download-artifact/releases/tag/v4.0.0,
and needs both `upload-artifact` _and_ `download-artifact` to be bumped.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This patch bumps the download-artifact to v4.

This implies a major architectural change according to
https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/
and https://github.com/actions/download-artifact/releases/tag/v4.0.0,
and needs both `upload-artifact` _and_ `download-artifact` to be bumped.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho requested a review from derrickstolee September 5, 2024 07:52
@dscho dscho self-assigned this Sep 5, 2024
Copy link

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this carefully!

@dscho dscho merged commit f6cad7c into vfs-2.46.0 Sep 5, 2024
91 checks passed
@dscho dscho deleted the update-actions branch September 5, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants