-
Notifications
You must be signed in to change notification settings - Fork 164
IPv6 support #1896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
IPv6 support #1896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@microsoft-github-policy-service agree company="Google" |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
rchiodo
reviewed
May 22, 2025
rchiodo
approved these changes
May 22, 2025
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Looks good. Thanks for the submission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Support for IPv6 addresses
This PR addresses #1252.
This change tries to better generalize the host address in order to support both IPv4 and IPv6 address families
In this PR the debug workflows have changed in the following manner:
{host}:{port}
path, the host can now utilize[::1]
or any other IPv6 address[::1]
127.0.0.1
Nuances:
getsockname
will always return >= 2 (2 in the case of IPv4 and 4 in the case of IPv6) so to ensure that there is no complicated branching logic we always take a [:2] slice.127.0.0.1
to either127.0.0.1
or::1
we opted to refer to the host when utilizing these values as localhost