Skip to content

Commit 35ccfc5

Browse files
authored
Merge pull request #193 from wravery/cleanup
schemagen bug fixes and cleanup
2 parents 9914c36 + 9af577b commit 35ccfc5

File tree

77 files changed

+468
-438
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

77 files changed

+468
-438
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ add_subdirectory(src)
8888

8989
if(GRAPHQL_BUILD_TESTS OR GRAPHQL_UPDATE_SAMPLES)
9090
add_subdirectory(samples)
91-
91+
9292
if(GRAPHQL_BUILD_TESTS)
9393
include(CTest)
9494
add_subdirectory(test)

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Introduction
1+
# Introduction
22

33
![Windows](https://github.com/microsoft/cppgraphqlgen/workflows/Windows/badge.svg)
44
![macOS](https://github.com/microsoft/cppgraphqlgen/workflows/macOS/badge.svg)

cmake/version.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
4.0.0
1+
4.0.1

doc/awaitable.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ public:
170170
}
171171

172172
...
173-
173+
174174
void return_value(const T& value) noexcept(std::is_nothrow_copy_constructible_v<T>)
175175
{
176176
_promise.set_value(value);
@@ -226,7 +226,7 @@ public:
226226
}
227227

228228
...
229-
229+
230230
void return_value(const T& value) noexcept(std::is_nothrow_copy_constructible_v<T>)
231231
{
232232
_promise.set_value(value);

doc/resolvers.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ struct RequestResolveParams
5454
};
5555
```
5656

57-
The only parameter which cannot be default initialized is `query`.
57+
The only parameter which cannot be default initialized is `query`.
5858

5959
The `service::await_async` launch policy is described in [awaitable.md](./awaitable.md).
6060
By default, the resolvers will run on the same thread synchronously.
@@ -126,13 +126,13 @@ on whether or not `T` matches those concepts:
126126
namespace methods::AppointmentHas {
127127

128128
template <class TImpl>
129-
concept getIdWithParams = requires (TImpl impl, service::FieldParams params)
129+
concept getIdWithParams = requires (TImpl impl, service::FieldParams params)
130130
{
131131
{ service::AwaitableScalar<response::IdType> { impl.getId(std::move(params)) } };
132132
};
133133

134134
template <class TImpl>
135-
concept getId = requires (TImpl impl)
135+
concept getId = requires (TImpl impl)
136136
{
137137
{ service::AwaitableScalar<response::IdType> { impl.getId() } };
138138
};

include/SchemaLoader.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,8 @@ class SchemaLoader
264264
std::string getOutputCppType(const OutputField& field) const noexcept;
265265

266266
private:
267+
static bool isExtension(const peg::ast_node& definition) noexcept;
268+
267269
void visitDefinition(const peg::ast_node& definition);
268270

269271
void visitSchemaDefinition(const peg::ast_node& schemaDefinition);

include/graphqlservice/internal/Version.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010

1111
namespace graphql::internal {
1212

13-
constexpr std::string_view FullVersion { "4.0.0" };
13+
constexpr std::string_view FullVersion { "4.0.1" };
1414

1515
constexpr size_t MajorVersion = 4;
1616
constexpr size_t MinorVersion = 0;
17-
constexpr size_t PatchVersion = 0;
17+
constexpr size_t PatchVersion = 1;
1818

1919
} // namespace graphql::internal
2020

res/ClientGen.rc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33

44
#include <winver.h>
55

6-
#define GRAPHQL_RC_VERSION 4,0,0,0
7-
#define GRAPHQL_RC_VERSION_STR "4.0.0"
6+
#define GRAPHQL_RC_VERSION 4,0,1,0
7+
#define GRAPHQL_RC_VERSION_STR "4.0.1"
88

99
#ifndef DEBUG
1010
#define VER_DEBUG 0

res/SchemaGen.rc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33

44
#include <winver.h>
55

6-
#define GRAPHQL_RC_VERSION 4,0,0,0
7-
#define GRAPHQL_RC_VERSION_STR "4.0.0"
6+
#define GRAPHQL_RC_VERSION 4,0,1,0
7+
#define GRAPHQL_RC_VERSION_STR "4.0.1"
88

99
#ifndef DEBUG
1010
#define VER_DEBUG 0

res/graphqlclient_version.rc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33

44
#include <winver.h>
55

6-
#define GRAPHQL_RC_VERSION 4,0,0,0
7-
#define GRAPHQL_RC_VERSION_STR "4.0.0"
6+
#define GRAPHQL_RC_VERSION 4,0,1,0
7+
#define GRAPHQL_RC_VERSION_STR "4.0.1"
88

99
#ifndef DEBUG
1010
#define VER_DEBUG 0

0 commit comments

Comments
 (0)