Skip to content

Commit 9914c36

Browse files
authored
Merge pull request #189 from wravery/next
Re-use the same Library.rc.in and Generator.rc.in files across targets
2 parents dc68395 + 24957b2 commit 9914c36

File tree

6 files changed

+25
-70
lines changed

6 files changed

+25
-70
lines changed

cmake/ClientGen.rc.in renamed to cmake/Generator.rc.in

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33

44
#include <winver.h>
55

6-
#define CLIENTGEN_RC_VERSION @CLIENTGEN_RC_VERSION@
7-
#define CLIENTGEN_RC_VERSION_STR "@CLIENTGEN_RC_VERSION_STR@"
6+
#define GRAPHQL_RC_VERSION @GRAPHQL_RC_VERSION@
7+
#define GRAPHQL_RC_VERSION_STR "@GRAPHQL_RC_VERSION_STR@"
88

99
#ifndef DEBUG
1010
#define VER_DEBUG 0
@@ -13,8 +13,8 @@
1313
#endif
1414

1515
VS_VERSION_INFO VERSIONINFO
16-
FILEVERSION CLIENTGEN_RC_VERSION
17-
PRODUCTVERSION CLIENTGEN_RC_VERSION
16+
FILEVERSION GRAPHQL_RC_VERSION
17+
PRODUCTVERSION GRAPHQL_RC_VERSION
1818
FILEFLAGSMASK VS_FFI_FILEFLAGSMASK
1919
FILEFLAGS VER_DEBUG
2020
FILEOS VOS__WINDOWS32
@@ -27,12 +27,12 @@ BEGIN
2727
BEGIN
2828
VALUE "CompanyName", "Microsoft Corporation"
2929
VALUE "FileDescription", "Code generator for https://github.com/microsoft/cppgraphqlgen"
30-
VALUE "FileVersion", CLIENTGEN_RC_VERSION_STR
31-
VALUE "InternalName", "clientgen"
30+
VALUE "FileVersion", GRAPHQL_RC_VERSION_STR
31+
VALUE "InternalName", "@GRAPHQL_RC_FILENAME@"
3232
VALUE "LegalCopyright", "Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License."
33-
VALUE "OriginalFilename", "clientgen.exe"
33+
VALUE "OriginalFilename", "@GRAPHQL_RC_FILENAME@.exe"
3434
VALUE "ProductName", "CppGraphQLGen"
35-
VALUE "ProductVersion", CLIENTGEN_RC_VERSION_STR
35+
VALUE "ProductVersion", GRAPHQL_RC_VERSION_STR
3636
END
3737
END
3838

File renamed without changes.

cmake/SchemaGen.rc.in

Lines changed: 0 additions & 43 deletions
This file was deleted.

res/ClientGen.rc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33

44
#include <winver.h>
55

6-
#define CLIENTGEN_RC_VERSION 4,0,0,0
7-
#define CLIENTGEN_RC_VERSION_STR "4.0.0"
6+
#define GRAPHQL_RC_VERSION 4,0,0,0
7+
#define GRAPHQL_RC_VERSION_STR "4.0.0"
88

99
#ifndef DEBUG
1010
#define VER_DEBUG 0
@@ -13,8 +13,8 @@
1313
#endif
1414

1515
VS_VERSION_INFO VERSIONINFO
16-
FILEVERSION CLIENTGEN_RC_VERSION
17-
PRODUCTVERSION CLIENTGEN_RC_VERSION
16+
FILEVERSION GRAPHQL_RC_VERSION
17+
PRODUCTVERSION GRAPHQL_RC_VERSION
1818
FILEFLAGSMASK VS_FFI_FILEFLAGSMASK
1919
FILEFLAGS VER_DEBUG
2020
FILEOS VOS__WINDOWS32
@@ -27,12 +27,12 @@ BEGIN
2727
BEGIN
2828
VALUE "CompanyName", "Microsoft Corporation"
2929
VALUE "FileDescription", "Code generator for https://github.com/microsoft/cppgraphqlgen"
30-
VALUE "FileVersion", CLIENTGEN_RC_VERSION_STR
30+
VALUE "FileVersion", GRAPHQL_RC_VERSION_STR
3131
VALUE "InternalName", "clientgen"
3232
VALUE "LegalCopyright", "Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License."
3333
VALUE "OriginalFilename", "clientgen.exe"
3434
VALUE "ProductName", "CppGraphQLGen"
35-
VALUE "ProductVersion", CLIENTGEN_RC_VERSION_STR
35+
VALUE "ProductVersion", GRAPHQL_RC_VERSION_STR
3636
END
3737
END
3838

res/SchemaGen.rc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33

44
#include <winver.h>
55

6-
#define SCHEMAGEN_RC_VERSION 4,0,0,0
7-
#define SCHEMAGEN_RC_VERSION_STR "4.0.0"
6+
#define GRAPHQL_RC_VERSION 4,0,0,0
7+
#define GRAPHQL_RC_VERSION_STR "4.0.0"
88

99
#ifndef DEBUG
1010
#define VER_DEBUG 0
@@ -13,8 +13,8 @@
1313
#endif
1414

1515
VS_VERSION_INFO VERSIONINFO
16-
FILEVERSION SCHEMAGEN_RC_VERSION
17-
PRODUCTVERSION SCHEMAGEN_RC_VERSION
16+
FILEVERSION GRAPHQL_RC_VERSION
17+
PRODUCTVERSION GRAPHQL_RC_VERSION
1818
FILEFLAGSMASK VS_FFI_FILEFLAGSMASK
1919
FILEFLAGS VER_DEBUG
2020
FILEOS VOS__WINDOWS32
@@ -27,12 +27,12 @@ BEGIN
2727
BEGIN
2828
VALUE "CompanyName", "Microsoft Corporation"
2929
VALUE "FileDescription", "Code generator for https://github.com/microsoft/cppgraphqlgen"
30-
VALUE "FileVersion", SCHEMAGEN_RC_VERSION_STR
30+
VALUE "FileVersion", GRAPHQL_RC_VERSION_STR
3131
VALUE "InternalName", "schemagen"
3232
VALUE "LegalCopyright", "Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT License."
3333
VALUE "OriginalFilename", "schemagen.exe"
3434
VALUE "ProductName", "CppGraphQLGen"
35-
VALUE "ProductVersion", SCHEMAGEN_RC_VERSION_STR
35+
VALUE "ProductVersion", GRAPHQL_RC_VERSION_STR
3636
END
3737
END
3838

src/CMakeLists.txt

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ if(GRAPHQL_UPDATE_VERSION)
2626

2727
set(GRAPHQL_RC_FILENAME "${target}")
2828

29-
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/../cmake/Version.rc.in
29+
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/../cmake/Library.rc.in
3030
${CMAKE_CURRENT_BINARY_DIR}/${target}_version.rc
3131
@ONLY)
3232

@@ -176,10 +176,9 @@ if(GRAPHQL_BUILD_CLIENTGEN)
176176
if(GRAPHQL_UPDATE_VERSION)
177177
add_dependencies(clientgen update_version_h)
178178

179-
set(CLIENTGEN_RC_VERSION "${PROJECT_VERSION_MAJOR},${PROJECT_VERSION_MINOR},${PROJECT_VERSION_PATCH},0")
180-
set(CLIENTGEN_RC_VERSION_STR "${PROJECT_VERSION}")
179+
set(GRAPHQL_RC_FILENAME "clientgen")
181180

182-
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/../cmake/ClientGen.rc.in
181+
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/../cmake/Generator.rc.in
183182
${CMAKE_CURRENT_BINARY_DIR}/ClientGen.rc
184183
@ONLY)
185184

@@ -215,10 +214,9 @@ if(GRAPHQL_BUILD_SCHEMAGEN)
215214
if(GRAPHQL_UPDATE_VERSION)
216215
add_dependencies(schemagen update_version_h)
217216

218-
set(SCHEMAGEN_RC_VERSION "${PROJECT_VERSION_MAJOR},${PROJECT_VERSION_MINOR},${PROJECT_VERSION_PATCH},0")
219-
set(SCHEMAGEN_RC_VERSION_STR "${PROJECT_VERSION}")
217+
set(GRAPHQL_RC_FILENAME "schemagen")
220218

221-
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/../cmake/SchemaGen.rc.in
219+
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/../cmake/Generator.rc.in
222220
${CMAKE_CURRENT_BINARY_DIR}/SchemaGen.rc
223221
@ONLY)
224222

0 commit comments

Comments
 (0)