Skip to content

feat: avoid consuming repeated agent message #6351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: avoid consuming repeated agent message #6351

wants to merge 6 commits into from

Conversation

thorseraq
Copy link

@thorseraq thorseraq commented Apr 21, 2025 •
edited
Loading

Why are these changes needed?

Related issue number

Closes #6317

Checks

@thorseraq thorseraq mentioned this pull request Apr 21, 2025
Open
1 task
@thorseraq
Copy link
Author

@microsoft-github-policy-service agree

@thorseraq thorseraq force-pushed the feature/250422_msg_id branch from 68c19ce to 7b04c71 Compare April 26, 2025 11:48
@thorseraq thorseraq changed the title feat: Add id field for AgentChat messages feat: Avoid consuming repeated agent message Apr 26, 2025
@thorseraq thorseraq changed the title feat: Avoid consuming repeated agent message feat: avoid consuming repeated agent message Apr 26, 2025
@thorseraq thorseraq marked this pull request as ready for review April 26, 2025 11:50
ekzhu
ekzhu reviewed Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some unit tests for AssistantAgent for checking the full_message_id matches between the stream chunk event and the final message.

@thorseraq thorseraq force-pushed the feature/250422_msg_id branch from a7034fb to 2d50904 Compare May 4, 2025 06:38
@thorseraq
Copy link
Author

thorseraq commented May 4, 2025 •
edited
Loading

Can we add some unit tests for AssistantAgent for checking the full_message_id matches between the stream chunk event and the final message.

Sure! glad to see reviews, test has been added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekzhu ekzhu ekzhu left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AgentChat messages should have an id field.
2 participants
@thorseraq @ekzhu