Undocked Reg-Free WinRT Activation isn’t enabled for Packaged Self-Contained apps on < 19H1 devices #5623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssparach
changed the title
Scottj1s
reviewed
Jul 15, 2025
| @@ -13,10 +13,13 @@ | |||
|
|
|||
| #include <../Detours/detours.h> | |||
|
|
|||
| static bool isPackaged = AppModel::Identity::IsPackagedProcess(); | |||
| static bool is19H1OrGreater = WindowsVersion::IsWindows10_19H1OrGreater(); | |||
|
|
|||
| static HRESULT DetoursInitialize() | |||
| { | |||
| // Only detour APIs for not-packaged processes | |||
There was a problem hiding this comment.
Suggested change
| // Only detour APIs for not-packaged processes | |
| // Detours needed for Lifted Reg-Free WinRT Activation before 19H1, and Dynamic Dependencies in unpackaged apps |
Scottj1s
reviewed
Jul 15, 2025
Comment on lines
+36
to
+40
| if (!isPackaged && !is19H1OrGreater) | ||
| { | ||
| FAIL_FAST_IF_FAILED(MddDetourPackageGraphInitialize()); | ||
| FAIL_FAST_IF_FAILED(UrfwInitialize()); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (!isPackaged && !is19H1OrGreater) | |
| { | |
| FAIL_FAST_IF_FAILED(MddDetourPackageGraphInitialize()); | |
| FAIL_FAST_IF_FAILED(UrfwInitialize()); | |
| } | |
| if (!isPackaged) | |
| { | |
| FAIL_FAST_IF_FAILED(MddDetourPackageGraphInitialize()); | |
| } | |
| if (!is19H1OrGreater) | |
| { | |
| FAIL_FAST_IF_FAILED(UrfwInitialize()); | |
| } |
Scottj1s
reviewed
Jul 15, 2025
| { | ||
| FAIL_FAST_IF_FAILED(MddDetourPackageGraphInitialize()); | ||
| FAIL_FAST_IF_FAILED(UrfwInitialize()); | ||
| } | ||
| FAIL_FAST_IF_WIN32_ERROR(DetourTransactionCommit()); | ||
| return S_OK; | ||
| } | ||
|
|
||
| static HRESULT DetoursShutdown() | ||
| { | ||
| // Only detour APIs for not-packaged processes |
There was a problem hiding this comment.
Suggested change
| // Only detour APIs for not-packaged processes | |
| // Detours needed for Lifted Reg-Free WinRT Activation before 19H1, and Dynamic Dependencies in unpackaged apps |
Scottj1s
reviewed
Jul 15, 2025
Comment on lines
+62
to
+66
| if (!isPackaged && !is19H1OrGreater) | ||
| { | ||
| UrfwShutdown(); | ||
| MddDetourPackageGraphShutdown(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (!isPackaged && !is19H1OrGreater) | |
| { | |
| UrfwShutdown(); | |
| MddDetourPackageGraphShutdown(); | |
| } | |
| if (!is19H1OrGreater) | |
| { | |
| UrfwShutdown(); | |
| } | |
| if (!isPackaged) | |
| { | |
| MddDetourPackageGraphShutdown(); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for #3133
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.