Skip to content

Changing Push Notification Create Channel error result to ERROR_NOT_SUPPORTED #5589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Changing Push Notification Create Channel error result to ERROR_NOT_SUPPORTED #5589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4461ffd
Changing test to correct expected error
guimafelipe Jul 2, 2025
f9b3cbe
Fixing the method
guimafelipe Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/PushNotifications/PushNotificationManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ namespace winrt::Microsoft::Windows::PushNotifications::implementation
{
co_return winrt::make<PushNotificationCreateChannelResult>(
nullptr,
E_FAIL,
HRESULT_FROM_WIN32(ERROR_NOT_SUPPORTED),
PushNotificationChannelStatus::CompletedFailure);
}

Expand Down
8 changes: 4 additions & 4 deletions test/PushNotificationTests/BaseTestSuite.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) Microsoft Corporation and Contributors. All rights reserved.
// Copyright (c) Microsoft Corporation and Contributors. All rights reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

#include "pch.h"
Expand Down Expand Up @@ -97,7 +97,7 @@ void BaseTestSuite::ChannelRequestUsingNullRemoteId()
else
{
auto channelOperation{ PushNotificationManager::Default().CreateChannelAsync(winrt::guid()) };
VERIFY_ARE_EQUAL(ChannelRequestHelper(channelOperation), E_FAIL);
VERIFY_ARE_EQUAL(ChannelRequestHelper(channelOperation), HRESULT_FROM_WIN32(ERROR_NOT_SUPPORTED));
}
}

Expand All @@ -111,7 +111,7 @@ void BaseTestSuite::ChannelRequestUsingRemoteId()
else
{
auto channelOperation{ PushNotificationManager::Default().CreateChannelAsync(c_azureRemoteId) };
VERIFY_ARE_EQUAL(ChannelRequestHelper(channelOperation), E_FAIL);
VERIFY_ARE_EQUAL(ChannelRequestHelper(channelOperation), HRESULT_FROM_WIN32(ERROR_NOT_SUPPORTED));
}
}

Expand All @@ -135,7 +135,7 @@ void BaseTestSuite::ChannelRequestCheckExpirationTime()
else
{
auto channelOperation{ PushNotificationManager::Default().CreateChannelAsync(c_azureRemoteId) };
VERIFY_ARE_EQUAL(ChannelRequestHelper(channelOperation), E_FAIL);
VERIFY_ARE_EQUAL(ChannelRequestHelper(channelOperation), HRESULT_FROM_WIN32(ERROR_NOT_SUPPORTED));
}
}

Expand Down
Loading