[Fix] Locating Microsoft.WindowsAppRuntime.pri in framework usage #5582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Hong-Xiang
changed the title
Scottj1s
reviewed
Jul 1, 2025
Scottj1s
reviewed
Jul 1, 2025
Scottj1s
reviewed
Jul 1, 2025
Scottj1s
reviewed
Jul 1, 2025
Scottj1s
reviewed
Jul 1, 2025
Hong-Xiang
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DrusTheAxe
requested changes
Jul 14, 2025
DrusTheAxe
reviewed
Jul 14, 2025
DrusTheAxe
reviewed
Jul 14, 2025
added 2 commits
July 15, 2025 11:01
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Scottj1s
reviewed
Jul 15, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Scottj1s
approved these changes
Jul 16, 2025
|
Hi @DrusTheAxe, the code has been updated to use WIL APIs, and all calls to package graph-related APIs have been removed. Could you please check if there are still any requested changes? |
Hong-Xiang
deleted the
user/xianghong/fix-pri-loadinig-for-framework-usage-1.8exp4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In framework deployment scenario, the Microsoft.WindowsAppRuntime.pri is installed in the WinodowsAppRuntime's msix installation folder, not the folder of app using WinAppSDK, the resource manager need to handle that case.
Current code is copy from WinUI's code (with minimum modification) handling this same problem from
With this fix localization would work in both self-contained and framework sceario.