Merge branch 'main' of github.com:microsoft/WindowsAppSDK into user/DinahK-2SO/StoragePickers_errorHandling

Author: DinahK-2SO

build/AzurePipelinesTemplates/WindowsAppSDK-BuildFoundation-Steps.yml

@@ -84,7 +84,7 @@ steps:
       msBuildCommandline: 'msbuild.exe /restore /nologo /nr:false /p:configuration=Release /p:platform=x64 $(Build.SourcesDirectory)\WindowsAppRuntime.sln'
       # Generally speaking, we leave it to the external repos to scan the bits in their packages.
       excludedPaths: |
-        $(Build.SourcesDirectory)\packages
+        $(Agent.ToolsDirectory)\uCRT\#$(Build.SourcesDirectory)\obj\$(buildConfiguration)\$(buildPlatform)#$(Build.SourcesDirectory)\packages
     env:
       SYSTEM_ACCESSTOKEN: $(System.AccessToken)
     continueOnError: true

build/AzurePipelinesTemplates/WindowsAppSDK-RunTestsInPipeline-Job.yml

@@ -57,6 +57,8 @@ jobs:
     testPayloadArtifactDir: $(Build.SourcesDirectory)\BuildOutput\$(buildConfiguration)\$(buildPlatform)
     AZURE_PIPELINES_DEDUP_PARALLELISM: 16
     artifactAttempt: ''
+    ob_artifactSuffix: '_$(buildConfiguration)$(buildPlatform)_$(Agent.JobStatus)$(artifactAttempt)'
+    ob_artifactBaseName: '$(System.StageName)_$(imageName)'
   steps:
     - template: WindowsAppSDK-RunTests-Steps.yml
       parameters:

build/ProjectReunion-CI.yml

@@ -182,9 +182,13 @@ jobs:
   - BuildMRT
   variables:
     testPayloadArtifactDir: $(Build.SourcesDirectory)\BuildOutput\$(buildConfiguration)\$(buildPlatform)
+    artifactAttempt: ''
+    ob_artifactSuffix: '_$(buildConfiguration)$(buildPlatform)_$(Agent.JobStatus)$(artifactAttempt)'
+    ob_artifactBaseName: '$(System.StageName)_$(imageName)'
   steps:
   - template: AzurePipelinesTemplates\WindowsAppSDK-RunTests-Steps.yml
     parameters:
       buildPlatform: $(buildPlatform)
       buildConfiguration: $(buildConfiguration)
       testLocale: $(testLocale)
+      ImageName: $(imageName)

dev/BackgroundTask/BackgroundTaskBuilder/BackgroundTaskBuilder.h

@@ -10,7 +10,7 @@ namespace winrt::Microsoft::Windows::ApplicationModel::Background::implementatio
 {
     struct BackgroundTaskBuilder : BackgroundTaskBuilderT<BackgroundTaskBuilder>
     {
-        BackgroundTaskBuilder()
+        BackgroundTaskBuilder(): m_taskEntryPointClsid{}
         {
             THROW_HR_IF(E_NOTIMPL, !::Microsoft::Windows::ApplicationModel::Background::Feature_BackgroundTask::IsEnabled());
         }

dev/Detours/disasm.cpp

@@ -334,6 +334,10 @@ CDetourDis::CDetourDis(_Out_opt_ PBYTE *ppbTarget, _Out_opt_ LONG *plExtra)
     m_bF3 = FALSE;
     m_bVex = FALSE;
     m_bEvex = FALSE;
+    m_nSegmentOverride = 0;
+    m_lScratchExtra = 0;
+    m_pbScratchTarget = nullptr;
+    ZeroMemory(m_rbScratchDst, sizeof(m_rbScratchDst));
 
     m_ppbTarget = ppbTarget ? ppbTarget : &m_pbScratchTarget;
     m_plExtra = plExtra ? plExtra : &m_lScratchExtra;
@@ -3562,6 +3566,7 @@ CDetourDis::CDetourDis()
     m_pbTarget = (PBYTE)DETOUR_INSTRUCTION_TARGET_NONE;
     m_pbPool = NULL;
     m_lExtra = 0;
+    ZeroMemory(m_rbScratchDst, sizeof(m_rbScratchDst));
 }
 
 PBYTE CDetourDis::CopyInstruction(PBYTE pDst,
@@ -3965,6 +3970,7 @@ BYTE CDetourDis::PureCopy32(BYTE* pSource, BYTE* pDest)
 CDetourDis::CDetourDis()
 {
     m_pbTarget = (PBYTE)DETOUR_INSTRUCTION_TARGET_NONE;
+    ZeroMemory(m_rbScratchDst, sizeof(m_rbScratchDst));
 }
 
 PBYTE CDetourDis::CopyInstruction(PBYTE pDst,

dev/Detours/image.cpp

@@ -775,8 +775,25 @@ CImage::CImage()
     m_hMap = NULL;
     m_pMap = NULL;
 
+    m_nNextFileAddr = 0;
+    m_nNextVirtAddr = 0;
+
+    ZeroMemory(&m_DosHeader, sizeof(m_DosHeader));
+    ZeroMemory(&m_NtHeader, sizeof(m_NtHeader));
+    ZeroMemory(&m_SectionHeaders, sizeof(m_SectionHeaders));
+
+    m_nPrePE = 0;
+    m_cbPrePE = 0;
+    m_cbPostPE = 0;
+
     m_nPeOffset = 0;
     m_nSectionsOffset = 0;
+    m_nExtraOffset = 0;
+    m_nFileSize = 0;
+
+    m_nOutputVirtAddr = 0;
+    m_nOutputVirtSize = 0;
+    m_nOutputFileAddr = 0;
 
     m_pbOutputBuffer = NULL;
     m_cbOutputBuffer = 0;

dev/Interop/StoragePickers/Strings/StoragePickers.resw

@@ -120,4 +120,19 @@
   <data name="All Files" xml:space="preserve">
     <value>All Files</value>
   </data>
-</root>
+  <data name="IDS_APIERROR_INVALIDVIEWMODEVALUE" xml:space="preserve">
+    <value>The specified 'ViewMode' is invalid.</value>
+  </data>
+  <data name="IDS_APIERROR_INVALIDSUGGESTEDSTARTLOCATIONVALUE" xml:space="preserve">
+    <value>The specified 'SuggestedStartLocation' is invalid.</value>
+  </data>
+  <data name="IDS_APIERROR_IMPROPERFILEEXTENSION" xml:space="preserve">
+    <value>File extensions must begin with '.' and contain no wildcards.</value>
+  </data>
+  <data name="IDS_APIERROR_STRINGSNOEMBEDDEDNULLS" xml:space="preserve">
+    <value>Strings cannot have embedded nulls.</value>
+  </data>
+  <data name="IDS_APIERROR_MAXSAVEFILELENGTHEXCEEDED" xml:space="preserve">
+    <value>The suggested file name exceeds the maximum number of characters allowed.</value>
+  </data>
+</root>

dev/MRTCore/mrt/mrm/UnitTests/StringResult.UnitTests.cpp

@@ -42,6 +42,7 @@ struct StringResult_Struct
 
     StringResult_Struct()
     {
+        origRef = nullptr;
         shortStr = L"Bye!";
         medStr = L"Hello!";
         concatStr = L" What's Up?";

dev/MRTCore/mrt/mrm/UnitTests/TestFileUtils.cpp

@@ -15,7 +15,9 @@ namespace UnitTests
 {
 
 FileBasedTest::FileBasedTest() : m_runFrom(Current), m_pTestClassName(nullptr), m_pTestMethodName(nullptr), m_pClassDataSubfolder(nullptr)
-{}
+{
+    m_originalDir[0] = L'\0';
+}
 
 DWORD
 FileBasedTest::CreateDirectoryHierarchy(_In_ const WEX::Common::String& path)

dev/MRTCore/mrt/mrm/UnitTests/TestReverseMap.cpp

@@ -15,7 +15,7 @@ using namespace WEX::Logging;
 namespace UnitTests
 {
 
-TestReverseFileMap::TestReverseFileMap() : m_build(), m_pPriBuilder(NULL), m_pReverseFileMapBuilder(NULL), m_pReverseFileMap(NULL) {}
+TestReverseFileMap::TestReverseFileMap() : m_build(), m_pPriBuilder(NULL), m_pReverseFileMapBuilder(NULL), m_pReverseFileMap(NULL), m_pTestDI(nullptr), m_testDI(), m_pDecisionInfo(nullptr) {}
 
 HRESULT
 TestReverseFileMap::InitFromTestVars(__in PriSectionBuilder* pPriBuilder, __in UnifiedEnvironment* pEnvironment, __in PCWSTR pVarPrefix)